Review main Merged

93410[FEATURE] Introduce auto-discovery for EXT:form YAML configurations

Josua Vogel CR +2 V +2 Expert +1482 −592 updated 04/23/26, 16:44

Commit message

YAML configuration files for EXT:form are now discovered automatically
from every active extension. No TypoScript or PHP registration is
required any longer.

Each extension may ship one or more "form sets" by placing files in a
conventional directory layout, mirroring the Site Sets pattern:

  EXT:my_extension/
    Configuration/
      Form/
        MyFormSet/
          config.yaml

A Symfony service configurator (FormYamlCollectorConfigurator) scans
all active extensions at DI runtime and populates the new
FormYamlCollector service, which is injected into ConfigurationManager.

Sets are merged in ascending priority order (lower value = loaded first,
acts as base). The EXT:form core set "typo3/form-base" ships at
priority 10 in EXT:form/Configuration/Form/Base/. Extension sets
default to priority 100.

A disable mechanism allows individual sets to be excluded without
touching the providing extension:

  $GLOBALS['TYPO3_CONF_VARS']['EXTENSIONS']['form']['disabledSets'][]
      = 'vendor/set-name';

TypoScript-based registration via
  plugin.tx_form.settings.yamlConfigurations
  module.tx_form.settings.yamlConfigurations
is deprecated. Extensions must migrate to the directory convention
described above. EXT:form/Configuration/Yaml/FormSetup.yaml is
removed; its content is now provided by the auto-discovery base set.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Sven Liebert +1
  • Verified V +2 Done
    • Benni Mack +2
    • Sven Liebert +1
    • core-ci +1 CI

Issues 1

Files 98

Show 78 more files

Review log 3143

Show 1218 earlier messages
  1. Josua Vogel uploaded patch set 1 03/27/26, 20:48

  2. Josua Vogel abandoned the change 03/27/26, 20:49

  3. Josua Vogel restored the change 03/27/26, 20:51

  4. Josua Vogel uploaded patch set 2 03/27/26, 20:51

  5. Josua Vogel updated the commit message in patch set 3 03/27/26, 20:52

  6. core-ci voted on patch set 2 V -1 03/27/26, 21:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98923

  7. core-ci voted on patch set 1 V -1 03/27/26, 21:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98922

  8. core-ci voted on patch set 3 V -1 03/27/26, 21:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98924

  9. Josua Vogel uploaded patch set 4 V -1 03/29/26, 14:34

  10. core-ci voted on patch set 4 V -1 03/29/26, 15:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98986

  11. Josua Vogel uploaded patch set 5 V -1 03/29/26, 16:10

  12. core-ci voted on patch set 5 V -1 03/29/26, 16:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98987

  13. Josua Vogel uploaded patch set 6 V -1 03/29/26, 16:28

  14. core-ci voted on patch set 6 V -1 03/29/26, 16:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98988

  15. Stefan Bürk commented on patch set 6 03/30/26, 19:27

    FYI - Breaking means no-go for v14 anymore. Not looked through it, just read the commit message. Not sure if we really should enforce this as a breaking change even for v15 without something doing that. Not sure if "plugin level" removal is also good, I guessthat have been used wildely. And another question would be: How to override a registration from extension? Or is the way "disable it and register your own" in that case ? TBH not a deeply EXT:form user but I know my company uses this in some projects.
  16. Benni Mack uploaded patch set 7 V -1 03/30/26, 19:52

  17. Benni Mack updated the commit message in patch set 8 03/30/26, 19:54

  18. Benni Mack updated the commit message in patch set 9 03/30/26, 19:55

  1. Benni Mack commented on patch set 9 03/30/26, 19:55

    Reply

    It's not breaking anymore.
  2. core-ci voted on patch set 8 V -1 03/30/26, 20:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99113

  3. core-ci voted on patch set 9 V -1 03/30/26, 20:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99114

  4. core-ci voted on patch set 7 V -1 03/30/26, 20:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99112

  5. Josua Vogel uploaded patch set 10 V -1 03/31/26, 05:31

  6. core-ci voted on patch set 10 V +1 03/31/26, 05:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99208

  7. Sven Liebert commented on patch set 10 03/31/26, 05:48

    Here isn't anything breaking isn't it?
  8. Josua Vogel updated the commit message in patch set 11 V +1 03/31/26, 05:49

  9. Josua Vogel commented on patch set 11 03/31/26, 05:49

    Reply

    Yes, everyone uses plugin

    Reply

    Done
  10. Georg Ringer voted on patch set 10 CR +1 V +1 03/31/26, 05:57

  11. Sven Liebert voted on patch set 11 CR +1 V +1 03/31/26, 05:59

  12. Josua Vogel commented on patch set 11 03/31/26, 06:02

    Reply

    To be honest, almost everyone uses Typoscript registration, since it’s the only way to add custom elements or configurations to the Form Framework. However, it’s now merely deprecated. In the long run, the new method is simpler—Typoscript tends to lead to beginner mistakes, which this approach helps avoid. Otherwise, you couldn’t really override much in the past either. You have to define your own YAML file, which is loaded later and overrides the corresponding configurations. The same principle continues to apply here.
  13. core-ci voted on patch set 11 V +1 03/31/26, 06:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99215

  14. Stefan Bürk commented on patch set 11 CR -1 03/31/26, 06:17

    reviewing ...
  15. Josua Vogel uploaded patch set 12 CR +1 V +1 03/31/26, 06:47

  16. Stefan Bürk commented on patch set 11 CR 0 03/31/26, 06:55

    Reply

    Done
    Leaving one question - technically having more, and TBH cannot make the risk assesment in the short time now if everything is in good shape or possible tackable in the FF phase. Personally I can't give my vote on this but abstain from blocking it in case other have a better feeling and knowledge that this is really ready.

    Reply

    Done

    FormYamlCollectorConfigurator.php:62

    Is there a reason why no `EXT:form/ext_conf_template.txt` exists for this ? Possible because of the array nature ? Not sure what happens if one is added in the future and the configuration syncronization stuff in ExtensionConfiguration - at least if that is used at some point, possible from 3rd party code (extensions) ..... Not to block this for now, we can take care of that in the FF phase. But we should have a look on that again.
  17. Sven Liebert voted on patch set 12 CR +1 V +1 03/31/26, 06:58

  18. core-ci voted on patch set 12 V +1 03/31/26, 06:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99225

  19. Benni Mack commented on patch set 12 CR +2 V +2 03/31/26, 07:08

    FormYamlCollectorConfigurator.php:62 Reply

    Will merge now regardless of the comment, due to FF and comment stated it's not blocking
  20. Benni Mack merged patch set 13 03/31/26, 07:08

  21. Benjamin Franzke commented on patch set 13 03/31/26, 07:35

    FormYamlCollectorConfigurator.php:60

    Btw, ext_localconf.php is not loaded by the time when DI compiler passes are executed. Procedure is: * Load system/settings/… * build package manager * build container (or use cached) * load ext_localconf For this reason we generally avoid using any `$GLOBALS['TYPO3_CONF_VARS']` in compiler passes, because this configuration is: * not fully loaded yet * meant not to be cached (a change of EXTCONF will not trigger a DI-rebuild)
  22. Benjamin Franzke commented on patch set 13 03/31/26, 08:45

    Index.rst:100

    FYI: The removal of this anchors causes CI to fail, because they are referenced in older Feature.rst files: https://git.typo3.org/typo3/CI/cms/-/jobs/5510436#L38 > [2026-03-31T07:33:51.154000+00:00] app.WARNING: Inventory link with key "typo3/cms-form:concepts-configuration-yamlregistration-backend-addtyposcriptsetup" (concepts-configuration-yamlregistration-backend-addtyposcriptsetup) not found. {"rst-file":"Changelog/13.1/Feature-103439-TypoScriptProviderForSitesAndSets","type":"ref","targetReference":"concepts-configuration-yamlregistration-backend-addtyposcriptsetup","value":"YAML registration for the backend via addTypoScriptSetup()","linkType":"std:label","interlinkDomain":"typo3/cms-form"} [] [2026-03-31T07:34:06.495041+00:00] app.WARNING: Inventory link with key "typo3/cms-form:concepts-configuration-yamlregistration-backend-addtyposcriptsetup" (concepts-configuration-yamlregistration-backend-addtyposcriptsetup) not found. {"rst-file":"Changelog/13.1/Feature-103439-TypoScriptProviderForSitesAndSets","type":"ref","targetReference":"concepts-configuration-yamlregistration-backend-addtyposcriptsetup","value":"YAML registration for the backend via addTypoScriptSetup()","linkType":"std:label","interlinkDomain":"typo3/cms-form"} [] [2026-03-31T07:34:06.495131+00:00] app.WARNING: Inventory link with key "typo3/cms-form:concepts-configuration-yamlregistration-backend-addtyposcriptsetup" (concepts-configuration-yamlregistration-backend-addtyposcriptsetup) not found. {"rst-file":"Changelog/13.1/Feature-103439-TypoScriptProviderForSitesAndSets","type":"ref","targetReference":"concepts-configuration-yamlregistration-backend-addtyposcriptsetup","value":"YAML registration for the backend via addTypoScriptSetup()","linkType":"std:label","interlinkDomain":"typo3/cms-form"} [] @garvin@hick.ing we should check why pre-merge did not catch that, while it feels for successive patches in pre-merge now: https://review.typo3.org/c/Packages/TYPO3.CMS/+/93480/1#message-36c33b09ab4b6a9a68ee1ad26c53a000770dd13c
  23. Benjamin Franzke commented on patch set 13 03/31/26, 09:01

    Index.rst:100 Reply

    Resolving here, let's handle in: > 93482: [WIP][TASK] Fix link to EXT:form yaml configuration | https://review.typo3.org/c/Packages/TYPO3.CMS/+/93482
  24. Josua Vogel commented on patch set 13 04/23/26, 16:40

    FormYamlCollectorConfigurator.php:60 Reply Unresolved

    The concern about $GLOBALS['TYPO3_CONF_VARS'] does not apply here. The FormYamlCollectorConfigurator is a Symfony service configurator, not a compiler pass. A service configurator (declared via the configurator: key in Services.yaml) is called at service instantiation time, not at compile time. The Symfony PhpDumper generates PHP code that calls the configurator every time the service is first requested from the compiled container. This happens at runtime, during request processing. The FormYamlCollector service (which uses the configurator) is only instantiated when ConfigurationManager first needs it — which happens during request processing, well after ext_localconf.php has been loaded. At that point, $GLOBALS['TYPO3_CONF_VARS'] is fully populated. So the disabledSets mechanism reading $GLOBALS['TYPO3_CONF_VARS']['EXTENSIONS']['form']['disabledSets'] in the configurator is correct and works as expected.
  25. Josua Vogel commented on patch set 13 04/23/26, 16:44

    FormYamlCollectorConfigurator.php:62 Reply Unresolved

    Correct — ext_conf_template.txt only supports flat scalar values, not arrays like disabledSets. If ext_conf_template.txt is added later, disabledSets wouldn't be defined in the template, so the merge (mergeRecursiveWithOverrule) preserves existing values from ext_localconf.php / settings.php.