93414[FEATURE] Add SRI integrity support to CSS TypoScript includes
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Garvin Hicking +1
- Guido Schmechel +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Georg Ringer +2
- Guido Schmechel +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 15
- typo3/sysext/core/Classes/Page/AssetRenderer.php+14 −0
- typo3/sysext/core/Classes/Page/PageRenderer.php+46 −3
- typo3/sysext/core/Classes/Page/ResourceHashCollection.php2new+92 −0
- typo3/sysext/core/Classes/Security/ContentSecurityPolicy/HashProxy.php2+47 −6
- typo3/sysext/core/Classes/Security/ContentSecurityPolicy/HashValue.php+7 −0
- typo3/sysext/core/Documentation/Changelog/14.2/Feature-109187-AddIntegrityPropertyToCssIncludes.rst4new+62 −0
- typo3/sysext/core/Documentation/Changelog/14.2/Feature-109187-AutomaticSRIHashResolutionForResourceIncludes.rst4new+101 −0
- typo3/sysext/core/Tests/Functional/Page/PageRendererTest.php+2 −0
- typo3/sysext/core/Tests/Unit/Page/AssetRendererTest.php+5 −1
- typo3/sysext/core/Tests/Unit/Page/PageRendererFactoryTrait.php+2 −1
- typo3/sysext/frontend/Classes/Http/RequestHandler.php+11 −3
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_resource_rendering/Resources/Public/alternate.cssnew+1 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_resource_rendering/Resources/Public/alternate.jsnew+1 −0
- typo3/sysext/frontend/Tests/Functional/Rendering/Fixtures/ScriptAndLinkTagRenderingTest.typoscript+6 −2
- typo3/sysext/frontend/Tests/Functional/Rendering/ScriptAndLinkTagRenderingTest.php+5 −3
Review log 1620
-
Oliver Hader uploaded patch set 1 03/28/26, 11:00
-
core-ci voted on patch set 1 V -1 03/28/26, 11:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98947
-
Oliver Hader uploaded patch set 2
V -103/28/26, 12:04 -
core-ci voted on patch set 2 V -1 03/28/26, 12:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98953
-
Oliver Hader uploaded patch set 3
V -103/28/26, 12:36 -
Oliver Hader commented on patch set 3 03/28/26, 12:41
This change is ready for review. -
core-ci voted on patch set 3 V +1 03/28/26, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98956
-
Simon Schaufelberger commented on patch set 3 03/28/26, 12:53
ResourceHashCollection.php:78personal preference: i would put null always in the endHashProxy.php:189is this annotation really necessary?Feature-109187-AddIntegrityPropertyToCssIncludes.rst:34would it make sense to explain how to generate the integrity yourself?Feature-109187-AutomaticSRIHashResolutionForResourceIncludes.rst:5please use the same length as the title -
Oliver Hader uploaded patch set 4
V +103/28/26, 13:05 -
Oliver Hader commented on patch set 3 03/28/26, 13:05
ResourceHashCollection.php:78ReplyDoneHashProxy.php:189ReplyDoneFeature-109187-AddIntegrityPropertyToCssIncludes.rst:34ReplyThe `integrity` property existed be before already. However, it's fine to reference to https://developer.mozilla.org/en-US/docs/Web/Security/Defenses/Subresource_IntegrityFeature-109187-AutomaticSRIHashResolutionForResourceIncludes.rst:5ReplyDone -
Garvin Hicking commented on patch set 4 03/28/26, 13:06
Feature-109187-AddIntegrityPropertyToCssIncludes.rst:20Should we use "crossOrigin"? -
Garvin Hicking commented on patch set 4 CR +1 03/28/26, 13:28
Feature-109187-AddIntegrityPropertyToCssIncludes.rst:20ReplyAh ok we've missed to do that for JS already. -
core-ci voted on patch set 4 V +1 03/28/26, 13:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98957
-
Guido Schmechel voted on patch set 4 CR +1 V +1 03/28/26, 15:16
-
Simon Schaufelberger voted on patch set 4 CR +1 V +1 03/28/26, 15:26
-
Georg Ringer voted on patch set 4 CR +1 V +1 03/28/26, 16:26
-
Georg Ringer voted on patch set 4 CR +2 V +2 03/30/26, 06:15
-
Georg Ringer merged patch set 5 03/30/26, 06:15
-
Christian Kuhn commented on patch set 5 04/07/26, 14:31
Feature-109187-AutomaticSRIHashResolutionForResourceIncludes.rst:87not allowed use of named arguments. -
Garvin Hicking commented on patch set 5 04/08/26, 19:51
Feature-109187-AutomaticSRIHashResolutionForResourceIncludes.rst:87ReplyDone: https://review.typo3.org/c/Packages/TYPO3.CMS/+/93573 [DOCS] Remove invalid named arguments from changelog example