Review main Merged

93415[TASK] Improve naming in MvcPropertyMappingConfigurationServiceTest

Torben Hansen CR +2 V +2 Easy +22 −22 updated 03/28/26, 17:57

Commit message

Variables holding an instance of `MvcPropertyMappingConfigurationService`
are named `$requestHashService`, which is misleading and incorrect.

With this change, all affected variables to
`$mvcPropertyMappingConfigurationService` are changed to
reflect the actual class being instantiated.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 57

  1. Torben Hansen uploaded patch set 1 03/28/26, 11:19

  2. Oliver Klee voted on patch set 1 CR +1 V +1 03/28/26, 11:38

  3. core-ci voted on patch set 1 V -1 03/28/26, 11:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98950

  4. core-ci voted on patch set 1 V +1 03/28/26, 13:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98950

  5. Garvin Hicking voted on patch set 1 CR +1 V +1 03/28/26, 13:20

  6. Garvin Hicking voted on patch set 1 CR +2 V +2 03/28/26, 17:41

  7. Garvin Hicking merged patch set 2 03/28/26, 17:57