Review main Merged

93424[TASK] Allow advancing form steps in page creation wizard using "Enter"

Andreas Nedbal CR +2 V +2 Easy +20 −15 updated 03/30/26, 17:11

Commit message

Allow implicit form sumission by reacting to the submit event. In
order to allow the submit even to be dispatched, a `hidden` submitter
element is added, which instructs browsers to enable implicit
form submission. [1]

Please note that this also means that the regular FormEngine
pre-submit interceptors will now be enabled, which ensures
that a dialog pops up if required fields have not been
filled yet.

[1] https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#implicit-submission

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1217

  1. Andreas Nedbal uploaded patch set 1 03/30/26, 10:12

  2. core-ci voted on patch set 1 V -1 03/30/26, 10:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99033

  3. Andreas Nedbal rebased onto patch set 2 V -1 03/30/26, 11:01

  4. core-ci voted on patch set 1 V -1 03/30/26, 11:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99033

  5. core-ci voted on patch set 2 V -1 03/30/26, 11:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99044

  6. Andreas Nedbal rebased onto patch set 3 V -1 03/30/26, 12:46

  7. Benjamin Franzke commented on patch set 3 CR -1 03/30/26, 12:55

    form-engine-step.ts:106

    Can we use the forms `submit` event handler instead to avoid mimicking browser behavior?
  8. core-ci voted on patch set 3 V +1 03/30/26, 12:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99058

  9. Andreas Nedbal commented on patch set 3 03/30/26, 13:46

    form-engine-step.ts:106 Reply

    Tried to do so and it didn't work, I assume that the submit event is either caught by FormEngine earlier or it doesn't even fire (since there is no submit field in the form?) That's why I resorted to this simple mimicking.
  10. Benjamin Franzke uploaded patch set 4 CR -1 V +1 03/30/26, 14:37

  11. Benjamin Franzke commented on patch set 4 03/30/26, 14:37

    form-engine-step.ts:106 Reply

    Alright, thanks. So let's add a submitter, which also allows regular pre-submit interceptors to run.
  12. Georg Ringer commented on patch set 4 V -1 03/30/26, 14:41

    works for all steps except the last one "create new page"
  13. core-ci voted on patch set 4 V +1 03/30/26, 14:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99074

  14. Benjamin Franzke commented on patch set 4 03/30/26, 15:03

    Reply

    I agree that would be better, but this issue/change is about the form-field steps specifically. The summary step does not work, because the keyboard focus management should be improved (ENTER works, if the focus is moved to the button). This is of course not ideal, I've created a separates issue for that: https://forge.typo3.org/issues/109426 Fine for you?
  15. Georg Ringer commented on patch set 4 CR +1 V +1 03/30/26, 15:36

    fine for me, even though I dont why splitting it up is needed but as I can't fix it, whatever fits best the page wizard team
  16. Benjamin Franzke commented on patch set 4 CR +2 V +2 03/30/26, 17:11

  17. Benjamin Franzke merged patch set 5 03/30/26, 17:11