Review main Merged

93426[TASK] Move error states in formeditor tree to status api

Benjamin Kott CR +2 V +2 Hard +115 −186 updated 03/30/26, 15:57

Commit message

The form editor tree previously used CSS classes and overlay icon
swaps to indicate validation errors on nodes. This migrates to
the tree's statusInformation API, which provides a structured way
to communicate node status with proper severity levels, labels
and icons.

The validation error and child-has-error states are now expressed
as statusInformation entries with error and warning severity
respectively, replacing the CSS-class-based approach. The legacy
classList manipulation in the view-model is removed in favour of
the dedicated setNodeValidationError and setNodeChildHasError
methods that populate statusInformation internally.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Josua Vogel +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Josua Vogel +1
    • core-ci +1 CI

Issues 1

Files 12

Review log 1015

  1. Benjamin Kott uploaded patch set 1 03/30/26, 10:45

  2. Benjamin Kott rebased onto patch set 2 03/30/26, 10:59

  3. Benjamin Kott rebased onto patch set 3 03/30/26, 11:17

  4. core-ci voted on patch set 2 V -1 03/30/26, 11:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99042

  5. core-ci voted on patch set 1 V -1 03/30/26, 11:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99039

  6. core-ci voted on patch set 3 V -1 03/30/26, 12:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99049

  7. Josua Vogel rebased onto patch set 4 V -1 03/30/26, 13:29

  8. Josua Vogel voted on patch set 4 CR +1 V +1 03/30/26, 13:32

  9. core-ci voted on patch set 4 V +1 03/30/26, 14:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99065

  10. Benjamin Kott rebased onto patch set 5 CR +1 V +1 03/30/26, 15:09

  11. Josua Vogel voted on patch set 5 CR +1 V +1 03/30/26, 15:41

  12. core-ci voted on patch set 5 V +1 03/30/26, 15:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99082

  13. Georg Ringer voted on patch set 5 CR +1 V +1 03/30/26, 15:57

  14. Georg Ringer voted on patch set 5 CR +2 V +2 03/30/26, 15:57

  15. Georg Ringer merged patch set 6 03/30/26, 15:57