Review main Merged

93428[BUGFIX] Add missing null checks for collection element configuration

Benjamin Kott CR +2 V +2 Easy +6 −5 updated 03/30/26, 15:49

Commit message

The getPropertyCollectionElementConfiguration() method can return an
empty object when the property collection does not exist, causing a
TypeError when accessing the editors property directly.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Josua Vogel +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Josua Vogel +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 913

  1. Benjamin Kott uploaded patch set 1 03/30/26, 10:59

  2. Benjamin Kott rebased onto patch set 2 03/30/26, 11:17

  3. core-ci voted on patch set 1 V -1 03/30/26, 11:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99043

  4. core-ci voted on patch set 2 V -1 03/30/26, 12:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99048

  5. Josua Vogel rebased onto patch set 3 V -1 03/30/26, 13:27

  6. Josua Vogel voted on patch set 3 CR +1 V +1 03/30/26, 13:27

  7. Georg Ringer voted on patch set 3 CR +1 V +1 03/30/26, 13:29

  8. core-ci voted on patch set 3 V -1 03/30/26, 14:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99064

  9. Benjamin Kott rebased onto patch set 4 CR +1 V +1 03/30/26, 15:09

  10. Josua Vogel voted on patch set 4 CR +1 V +1 03/30/26, 15:42

  11. core-ci voted on patch set 4 V +1 03/30/26, 15:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99081

  12. Georg Ringer voted on patch set 4 CR +2 V +2 03/30/26, 15:49

  13. Georg Ringer merged patch set 5 03/30/26, 15:49