Review main Merged

93429[BUGFIX] Fix expected rel attribute order in ContentObjectRendererTest

Benjamin Kott CR +2 V +2 Easy +1 −1 updated 03/30/26, 12:44

Commit message

The test expectation for the rel attribute value did not match
the actual output after the recent change to make the rel
attribute in external links configurable.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Josua Vogel +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Josua Vogel +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Benjamin Kott uploaded patch set 1 03/30/26, 11:17

  2. Josua Vogel voted on patch set 1 CR +1 V +1 03/30/26, 11:25

  3. core-ci voted on patch set 1 V -1 03/30/26, 12:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99051

  4. Benjamin Kott uploaded patch set 2 CR +1 V +1 03/30/26, 12:14

  5. core-ci voted on patch set 2 V +1 03/30/26, 12:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99057

  6. Josua Vogel voted on patch set 2 CR +1 V +1 03/30/26, 12:30

  7. Benjamin Franzke voted on patch set 2 CR +2 V +2 03/30/26, 12:44

  8. Benjamin Franzke merged patch set 3 03/30/26, 12:44