Review main Merged

93452[TASK] Remove exclamation marks

Josef Glatz CR +2 V +2 Easy +3 −3 updated 03/31/26, 07:18

Commit message

This patch removes exclamation marks from strings
and follows similar previous changes. This patch
targets core, reactions and redirects.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Josua Vogel +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Josua Vogel +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1821

  1. Josef Glatz uploaded patch set 1 03/30/26, 22:22

  2. Josef Glatz commented on patch set 1 03/30/26, 22:23

    This change is ready for review.
  3. Josef Glatz updated the commit message in patch set 2 03/30/26, 22:24

  4. Josef Glatz commented on patch set 2 03/30/26, 22:26

    locallang_tsfe.xlf:26

    @benni@typo3.org let's change the look and feel of the link/button if we need to add more awareness to the "publish now" action!
  5. core-ci voted on patch set 2 V +1 03/30/26, 22:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99154

  6. core-ci voted on patch set 1 V +1 03/30/26, 22:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99153

  7. Georg Ringer voted on patch set 2 CR +1 V +1 03/31/26, 05:14

  8. Josua Vogel voted on patch set 2 CR +1 V +1 03/31/26, 06:12

  9. Simon Schaufelberger voted on patch set 2 CR +1 V +1 03/31/26, 06:50

  10. Riccardo De Contardi commented on patch set 2 03/31/26, 06:59

    short_urls.xlf:25

    On my patch https://review.typo3.org/c/Packages/TYPO3.CMS/+/93138 I wrote "No short URLs found."
  11. Benni Mack commented on patch set 2 CR +2 V +2 03/31/26, 06:59

    locallang_tsfe.xlf:26 Reply

    Ack
  12. Benni Mack voted on patch set 2 CR 0 V 0 03/31/26, 06:59

  13. Josef Glatz commented on patch set 3 CR +1 V +1 03/31/26, 07:07

    Published edit on patch set 2.
  14. Josef Glatz commented on patch set 3 03/31/26, 07:08

    short_urls.xlf:25 Reply

    Done
  15. Josua Vogel voted on patch set 3 CR +1 V +1 03/31/26, 07:09

  16. Riccardo De Contardi commented on patch set 3 03/31/26, 07:10

    short_urls.xlf:25 Reply

    In fact you missed the lowercale letter in "Short" AFAIC. I'll update my patch ASAP
  17. Georg Ringer voted on patch set 3 CR +1 V +1 03/31/26, 07:11

  18. core-ci voted on patch set 3 V +1 03/31/26, 07:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99226

  19. Simon Schaufelberger voted on patch set 3 CR +1 V +1 03/31/26, 07:17

  20. Benni Mack voted on patch set 3 CR +2 V +2 03/31/26, 07:18

  21. Benni Mack merged patch set 4 03/31/26, 07:18