Review main Merged

93475[TASK] Use `rawMessage` in PHPStan baseline

Elias Häußler CR +2 V +2 Normal +72 −69 updated 04/08/26, 11:01

Commit message

By using the `rawMessage` attribute, reading baseline entries is much
easier and may also increase performance since regex-parsing is omitted.

Used command:
> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1418

  1. Elias Häußler uploaded patch set 1 03/31/26, 05:45

  2. core-ci voted on patch set 1 V -1 03/31/26, 06:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99212

  3. Benjamin Franzke commented on patch set 1 04/02/26, 12:33

    ❤️
  4. Elias Häußler rebased onto patch set 2 V -1 04/06/26, 11:05

  5. Anja Leichsenring voted on patch set 2 CR +1 V +1 04/06/26, 11:11

  6. core-ci voted on patch set 2 V +1 04/06/26, 11:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99650

  7. Garvin Hicking voted on patch set 2 CR +1 V +1 04/06/26, 11:35

  8. Oliver Klee commented on patch set 2 04/06/26, 11:46

    Ticket ID missing
  9. Elias Häußler rebased onto patch set 3 CR +1 V +1 04/07/26, 13:57

  10. Elias Häußler commented on patch set 3 04/07/26, 13:58

    Reply

    Sorry, I was in a hurry :D I added the issue number.
  11. Elias Häußler commented on patch set 3 04/07/26, 13:58

    Reply

    Done
  12. Elias Häußler updated the commit message in patch set 4 04/07/26, 14:00

  13. Oliver Klee voted on patch set 4 CR +1 V +1 04/07/26, 14:01

  14. core-ci voted on patch set 4 V +1 04/07/26, 14:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99701

  15. core-ci voted on patch set 3 V +1 04/07/26, 14:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99700

  16. Garvin Hicking voted on patch set 4 CR +1 V +1 04/07/26, 16:52

  17. Christian Kuhn voted on patch set 4 CR +2 V +2 04/08/26, 11:01

  18. Christian Kuhn merged patch set 5 04/08/26, 11:01