93477[TASK] Add toggle for dark and light mode to Camino theme
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 4
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/77/93477/4 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/77/93477/4 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Relation chain 5
- main 93740[Task] add favicon, improve CSS
- main 93739[TASK] add favicon files, adjust CSS, prepare JS for sub-navigation
- main 93738[FEATURE] add theme switch for static website
- main 93481[BUGFIX] Assign colors by variables as far as possible.
-
93477 [TASK] Add toggle for dark and light mode to Camino theme This change
Issues 1
Files 17
- typo3/sysext/theme_camino/Configuration/Sets/camino/labels.xlf+21 −0
- typo3/sysext/theme_camino/Configuration/Sets/camino/settings.definitions.yaml+10 −0
- typo3/sysext/theme_camino/Documentation/Customize/Index.rst+21 −0
- typo3/sysext/theme_camino/Resources/Private/Language/messages.xlf+12 −0
- typo3/sysext/theme_camino/Resources/Private/Templates/Partials/Icons/CircleHalf.fluid.htmlnew+13 −0
- typo3/sysext/theme_camino/Resources/Private/Templates/Partials/Icons/Moon.fluid.htmlnew+10 −0
- typo3/sysext/theme_camino/Resources/Private/Templates/Partials/Icons/Sun.fluid.htmlnew+10 −0
- typo3/sysext/theme_camino/Resources/Private/Templates/Partials/Pages/ColorModeToggle.fluid.htmlnew+68 −0
- typo3/sysext/theme_camino/Resources/Private/Templates/Partials/Pages/Header.fluid.html+3 −1
- typo3/sysext/theme_camino/Resources/Public/Css/main.css+2 −0
- typo3/sysext/theme_camino/Resources/Public/Css/_base.css+1 −1
- typo3/sysext/theme_camino/Resources/Public/Css/_color-mode-toggle.cssnew+67 −0
- typo3/sysext/theme_camino/Resources/Public/Css/_color-mode.cssnew+103 −0
- typo3/sysext/theme_camino/Resources/Public/Css/_header.css+4 −3
- typo3/sysext/theme_camino/Resources/Public/JavaScript/color-mode.jsnew+73 −0
- typo3/sysext/theme_camino/Resources/Public/JavaScript/main.js+5 −0
- typo3/sysext/theme_camino/Tests/Functional/Rendering/ColorModeToggleRenderingTest.phpnew+150 −0
Review log 812
-
David Bruchmann uploaded patch set 1 03/31/26, 06:24
-
David Bruchmann rebased onto patch set 2 03/31/26, 06:28
-
Benjamin Kott commented on patch set 2 CR -1 03/31/26, 06:44
-
core-ci voted on patch set 1 V -1 03/31/26, 07:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99218
-
core-ci voted on patch set 2 V -1 03/31/26, 07:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99222
-
David Bruchmann commented on patch set 2 03/31/26, 07:34
_css-variables-dark-mode.css:23ReplyI changed the notation, which reduces also the code. Primary colors have to be redefined though with real colors, I think. -
David Bruchmann rebased onto patch set 3
CR -1V -104/20/26, 08:35 -
core-ci voted on patch set 3 V -1 04/20/26, 09:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100524
-
Garvin Hicking marked it work in progress 04/20/26, 16:29
-
Benni Mack uploaded patch set 4
V -111/12/26, 14:53 -
core-ci voted on patch set 4 V +1 11/12/26, 15:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114196
-
Benni Mack marked it ready for review 11/12/26, 16:11
_css-variables-dark-mode.css:23