Review main Merged

93478[BUGFIX] Fix dropdown position opened from modal

Ravi Sachaniya CR +2 V +2 Easy +1 −2 updated 04/02/26, 08:09

Commit message

In Firefox browser the position of the dropdown
inside of the modal was top left of the screen.

Removing the position absolute from the dropdown
fixes the issues in Firefox.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1217

  1. Ravi Sachaniya uploaded patch set 1 03/31/26, 06:37

  2. Ravi Sachaniya updated the commit message in patch set 2 03/31/26, 06:43

  3. core-ci voted on patch set 1 V +1 03/31/26, 06:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99223

  4. core-ci voted on patch set 2 V +1 03/31/26, 06:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99224

  5. Simon Schaufelberger voted on patch set 2 CR +1 V +1 03/31/26, 06:59

  6. Benjamin Franzke commented on patch set 2 CR -1 03/31/26, 07:26

    _modal.scss:34

    Thanks for your patch. This shows what our actual problem is: Seems we should remove `position: absolute` from `.dropdown` instead, as it would fix the issue as well and would be possible now that we use popover positioning (which actually uses `position: fixed` by default but is overwritten by us). Adding position relative here could have negative consequences that we can not foresee yet, but it basically fixes the (possibly) invalid absolute positioning in `.dropdown`. We'll check what causes us to use `position: absolute` (maybe it's just a left-over) and revisit this change. Thank you!
  7. Ravi Sachaniya uploaded patch set 3 CR +1 V +1 03/31/26, 07:49

  8. Ravi Sachaniya uploaded patch set 4 03/31/26, 07:52

  9. Ravi Sachaniya commented on patch set 4 03/31/26, 07:53

    _modal.scss:34 Reply

    Thanks for your review, I have revert change and also now removed the `position: absolute` from the `.dropdown` in the latest patch Thank you!
  10. core-ci voted on patch set 3 V +1 03/31/26, 08:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99231

  11. core-ci voted on patch set 4 V +1 03/31/26, 08:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99232

  12. Ravi Sachaniya updated the commit message in patch set 5 V +1 03/31/26, 11:45

  13. core-ci voted on patch set 5 V +1 03/31/26, 11:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99258

  14. Benjamin Franzke voted on patch set 5 CR +1 V +1 04/02/26, 08:09

  15. Benjamin Kott voted on patch set 5 CR +1 V +1 04/02/26, 08:09

  16. Benjamin Franzke voted on patch set 5 CR +2 V +2 04/02/26, 08:09

  17. Benjamin Franzke merged patch set 6 04/02/26, 08:09