Review main Merged

93482[DOCS] Readd removed anchors to form yaml documentation

Benjamin Franzke CR +2 V +2 Easy +5 −3 updated 03/31/26, 09:53

Commit message

With #109412 an anchor was removed that was still
referenced in an older Feature.rst file. To ensure
that existing permalinks continue to work, we reintroduce
the anchors and link to the generic "YAML registration"
chapter (which exists in main and v13) instead.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • Benjamin Kott +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1113

  1. Benjamin Franzke uploaded patch set 1 03/31/26, 09:00

  2. Benjamin Franzke commented on patch set 1 03/31/26, 09:02

    Will change to `[DOCS]` with next push ;)
  3. core-ci voted on patch set 1 V +1 03/31/26, 09:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99236

  4. Benjamin Franzke uploaded patch set 2 V +1 03/31/26, 09:13

  5. Benjamin Franzke commented on patch set 2 03/31/26, 09:13

    Reply

    Done
  6. Garvin Hicking commented on patch set 2 CR +1 V +1 03/31/26, 09:14

    Reply

    So the reason why this worked in the main patch but now fails in others patches is this: The rendering locally takes place and may check ONLINE references. This happens in case where references are made with `typo3/cms-form`. That means the RENDERED version is looked up for its references. That succeeded, because the online version was still the old version. Then the patch got merged, the docs got rendered, and now all other patches fail because the online version no longer has this anchor. We can only remedy this by checking all existing docs for use of "online identifiers" and change them to local identifiers, where the docs are maintained in the core repo. That'll be cumbersome, but I will add an issue for this.
  7. Garvin Hicking commented on patch set 2 03/31/26, 09:16

    Reply

    https://forge.typo3.org/issues/109433 Thanks for providing a fix and asking for the background!
  8. Benjamin Franzke commented on patch set 2 03/31/26, 09:17

    Reply

    ack, we guessed so, all good. Thanks for confirming and creating the issue ❤️
  9. core-ci voted on patch set 2 V +1 03/31/26, 09:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99239

  10. Benjamin Kott voted on patch set 2 CR +1 V +1 03/31/26, 09:25

  11. Benjamin Franzke voted on patch set 2 CR +2 V +2 03/31/26, 09:25

  12. Benjamin Franzke merged patch set 3 03/31/26, 09:26

  13. Oliver Hader voted on patch set 3 CR +1 03/31/26, 09:53