Review main Merged

93483[TASK] Improve ext_emconf.php deprecation message

Helmut Hummel CR +2 V +2 Easy +16 −7 updated 04/13/26, 17:30

Commit message

Typo3Information::getDocsLink() is declared static to make
clear this method can be used without side effects early
and without DI being ready.

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Helmut Hummel +2
    • Oliver Klee +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 2431

Show 46 earlier messages
  1. Helmut Hummel uploaded patch set 1 03/31/26, 09:11

  2. Helmut Hummel uploaded patch set 2 03/31/26, 09:22

  3. core-ci voted on patch set 2 V +1 03/31/26, 09:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99241

  4. core-ci voted on patch set 1 V -1 03/31/26, 09:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99238

  5. Andreas Kienast commented on patch set 2 03/31/26, 11:04

    Typo3Information.php:123

    IMO this deserves a comment that DI is not wanted here (for now) to avoid follow-up changes.
  6. Oliver Klee updated the commit message in patch set 3 V +1 03/31/26, 11:43

  1. core-ci voted on patch set 3 V +1 03/31/26, 11:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99257

  2. Helmut Hummel commented on patch set 3 04/07/26, 09:58

    Typo3Information.php:123 Reply

    The above code does not fail because of DI, but because it pulls in global state in constructor. But yes. Since this is triggered *before* DI is ready, it would also fail when DI is tried to be used (alongside the many usages in core, which also only create the instance with new)
  3. Christian Kuhn uploaded patch set 4 V +1 04/08/26, 11:22

  4. Christian Kuhn uploaded patch set 5 04/08/26, 11:25

  5. Christian Kuhn commented on patch set 5 04/08/26, 11:26

    Typo3Information.php:123 Reply

    I agree to Andy we should document this quite special case. I added a hopefully matching comment together with an @todo this should be sorted out in a better way.
  6. Christian Kuhn voted on patch set 5 CR +1 V +1 04/08/26, 11:26

  7. Oliver Klee voted on patch set 5 CR +1 04/08/26, 11:30

  8. Oliver Klee voted on patch set 5 V +1 04/08/26, 11:30

  9. Helmut Hummel commented on patch set 5 04/08/26, 11:30

    Typo3Information.php:123 Reply

    comment looks good. We could make getDocsLink static right away, what do you think about that?
  10. Christian Kuhn voted on patch set 5 CR -1 04/08/26, 11:32

  11. Christian Kuhn commented on patch set 5 04/08/26, 11:33

    Typo3Information.php:123 Reply

    yeah. will do.
  12. core-ci voted on patch set 5 V +1 04/08/26, 11:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99758

  13. Christian Kuhn uploaded patch set 6 CR +1 V +1 04/08/26, 11:43

  14. Christian Kuhn voted on patch set 6 CR +1 V +1 04/08/26, 11:44

  15. Oliver Klee voted on patch set 6 CR +1 04/08/26, 11:48

  16. core-ci voted on patch set 6 V +1 04/08/26, 11:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99760

  17. Oliver Klee voted on patch set 6 V +1 04/08/26, 12:01

  18. core-ci voted on patch set 4 V -1 04/08/26, 12:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99756

  19. Garvin Hicking commented on patch set 6 04/08/26, 13:38

    Typo3Information.php:123 Reply

    Even though a atic method can be called via $this, that method is a public non internal method and would be a BC as also third party extensions use this. I'm not against consciously doing this, but I wanted to point it out that we may make v13&v14 dual compat harder because of this.
  20. Helmut Hummel commented on patch set 6 04/09/26, 06:46

    Typo3Information.php:123 Reply

    @garvin@hick.ing How is it breaking? And how is it useful for third party extensions? Even if they use it and create an instance, there is no change for their code required
  21. core-ci voted on patch set 4 V +1 04/09/26, 06:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99756

  22. Helmut Hummel voted on patch set 6 CR +2 V +2 04/09/26, 06:49

  23. Helmut Hummel merged patch set 7 04/09/26, 06:49

  24. Garvin Hicking commented on patch set 7 04/09/26, 07:37

    Typo3Information.php:123 Reply

    I think phpstan will complain about a static method being called in object context. An an extension that wants to provide v13 compat cannot call it ststically.
  25. Christian Kuhn commented on patch set 7 04/13/26, 17:30

    Typo3Information.php:123 Reply

    A phpstan mumble is not a b/w break but rather a strict phpstan configuration. People that set this have to deal with the fallout to catch up sometimes. Doing this is perfectly fine from PHP PoV.