Review main Merged

93485[TASK] Offer to import bundled distributions during installation process

Benjamin Kott CR +2 V +2 Hard +264 −207 updated 04/01/26, 18:05

Commit message

By default `theme_camino` will be offered to be imported if installed
(always installed by default in classic mode, and available
if `typo3/theme-camino` has been required in composer mode).

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 1827

Show 12 earlier messages
  1. Benjamin Kott uploaded patch set 1 03/31/26, 09:30

  2. core-ci voted on patch set 1 V -1 03/31/26, 09:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99243

  1. Benjamin Franzke commented on patch set 1 03/31/26, 09:46

    SetupService.php:322

    We should try to use `BootService::makeCurrent()` here, or instead move the `loadExtLocalconfDatabaseAndExtTables()` call into this method and call it with `$resetContainer = false` to ensure that the container that was used to load localconf keeps global. We can then cleanup with `resetGlobalContainer` at the end, similar to the LANG/BE_USER cleanups below.
  2. Benni Mack commented on patch set 1 CR -1 03/31/26, 13:08

    SetupService.php:332

    can't do that, we need an Event where an EventListener from EXT:impexp can pick up. Otherwise, EXT:install has a dependency on EXT:impexp.
  3. Benjamin Franzke commented on patch set 1 03/31/26, 14:58

    SetupService.php:332 Reply

    Ack. Would a guard, to only enable this when `$container->has(Import::class)` is true, be fine to you?
  4. Benni Mack commented on patch set 1 03/31/26, 16:09

    SetupService.php:332 Reply

    fine for me for now - let's just get the basic foundation in as soon as possible.
  5. Benjamin Franzke uploaded patch set 2 CR -1 V -1 04/01/26, 08:09

  6. core-ci voted on patch set 2 V -1 04/01/26, 08:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99362

  7. Benjamin Franzke uploaded patch set 3 V -1 04/01/26, 08:38

  8. Benjamin Franzke commented on patch set 3 04/01/26, 08:40

    SetupService.php:322 Reply

    Done

    SetupService.php:332 Reply

    Done
  9. core-ci voted on patch set 3 V -1 04/01/26, 08:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99367

  10. Benjamin Franzke uploaded patch set 4 V -1 04/01/26, 09:57

  11. Benjamin Franzke uploaded patch set 5 04/01/26, 10:03

  12. core-ci voted on patch set 4 V -1 04/01/26, 10:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99382

  13. core-ci voted on patch set 5 V +1 04/01/26, 10:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99383

  14. Benjamin Franzke uploaded patch set 6 V +1 04/01/26, 10:15

  15. core-ci voted on patch set 6 V +1 04/01/26, 10:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99387

  16. Benjamin Franzke updated the commit message in patch set 7 V +1 04/01/26, 12:01

  17. Benjamin Franzke updated the commit message in patch set 8 04/01/26, 12:07

  18. core-ci voted on patch set 7 V +1 04/01/26, 12:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99397

  19. core-ci voted on patch set 8 V +1 04/01/26, 12:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99398

  20. Benjamin Franzke uploaded patch set 9 V +1 04/01/26, 12:59

  21. Benjamin Franzke commented on patch set 9 CR +1 V +1 04/01/26, 12:59

    Helpful script to test installation process over-and-over again ;) ``` #!/bin/sh rm -rf subdir/ mkdir subdir cd subdir ln -s ../typo3 ln -s ../index.php touch FIRST_INSTALL mkdir typo3conf/system/ -p cat > typo3conf/system/additional.php <<- EOF <?php \$GLOBALS['TYPO3_CONF_VARS']['BE']['entryPoint'] = 'admin'; \$GLOBALS['TYPO3_CONF_VARS']['DB']['Connections']['Default'] = [ 'charset' => 'utf8', 'driver' => 'pdo_sqlite', 'path' => dirname(__FILE__) . '/cms.sqlite', ]; EOF (sleep 1 && xdg-open http://127.0.0.1:8080/) & php -S 127.0.0.1:8080 -t . -d max_execution_time=240 -d max_input_vars=1500 ```
  22. core-ci voted on patch set 9 V +1 04/01/26, 13:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99405

  23. Benni Mack commented on patch set 9 CR +2 V +2 04/01/26, 13:41

    thanks!
  24. Benni Mack merged patch set 10 04/01/26, 13:41

  25. Garvin Hicking commented on patch set 10 04/01/26, 18:05

    Reply

    Thats really cool thx for sharing. I wonder where I can note this down to ever find it when I'll definitely need it.