93485[TASK] Offer to import bundled distributions during installation process
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Benjamin Franzke +1
-
Verified V +2 Done
- Benni Mack +2
- Benjamin Franzke +1
- core-ci +1 CI
Issues 1
Files 8
- typo3/sysext/core/Tests/Acceptance/Install/Mysql/BlankPageCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Install/Postgresql/BlankPageCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Install/Sqlite/BlankPageCest.php+1 −1
- typo3/sysext/install/Classes/Command/SetupCommand.php+68 −19
- typo3/sysext/install/Classes/Controller/InstallerController.php+24 −32
- typo3/sysext/install/Classes/Service/SetupService.php6+109 −99
- typo3/sysext/install/Classes/ServiceProvider.php+1 −0
- typo3/sysext/install/Resources/Private/Templates/Installer/ShowDefaultConfiguration.fluid.html+59 −54
Review log 1827
Show 12 earlier messages
-
Benjamin Kott uploaded patch set 1 03/31/26, 09:30
-
core-ci voted on patch set 1 V -1 03/31/26, 09:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99243
-
Benjamin Franzke commented on patch set 1 03/31/26, 09:46
-
Benni Mack commented on patch set 1 CR -1 03/31/26, 13:08
SetupService.php:332can't do that, we need an Event where an EventListener from EXT:impexp can pick up. Otherwise, EXT:install has a dependency on EXT:impexp. -
Benjamin Franzke commented on patch set 1 03/31/26, 14:58
SetupService.php:332ReplyAck. Would a guard, to only enable this when `$container->has(Import::class)` is true, be fine to you? -
Benni Mack commented on patch set 1 03/31/26, 16:09
SetupService.php:332Replyfine for me for now - let's just get the basic foundation in as soon as possible. -
Benjamin Franzke uploaded patch set 2
CR -1V -104/01/26, 08:09 -
core-ci voted on patch set 2 V -1 04/01/26, 08:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99362
-
Benjamin Franzke uploaded patch set 3
V -104/01/26, 08:38 -
Benjamin Franzke commented on patch set 3 04/01/26, 08:40
SetupService.php:322ReplyDoneSetupService.php:332ReplyDone -
core-ci voted on patch set 3 V -1 04/01/26, 08:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99367
-
Benjamin Franzke uploaded patch set 4
V -104/01/26, 09:57 -
Benjamin Franzke uploaded patch set 5 04/01/26, 10:03
-
core-ci voted on patch set 4 V -1 04/01/26, 10:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99382
-
core-ci voted on patch set 5 V +1 04/01/26, 10:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99383
-
Benjamin Franzke uploaded patch set 6
V +104/01/26, 10:15 -
core-ci voted on patch set 6 V +1 04/01/26, 10:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99387
-
Benjamin Franzke updated the commit message in patch set 7
V +104/01/26, 12:01 -
Benjamin Franzke updated the commit message in patch set 8 04/01/26, 12:07
-
core-ci voted on patch set 7 V +1 04/01/26, 12:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99397
-
core-ci voted on patch set 8 V +1 04/01/26, 12:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99398
-
Benjamin Franzke uploaded patch set 9
V +104/01/26, 12:59 -
Benjamin Franzke commented on patch set 9 CR +1 V +1 04/01/26, 12:59
Helpful script to test installation process over-and-over again ;) ``` #!/bin/sh rm -rf subdir/ mkdir subdir cd subdir ln -s ../typo3 ln -s ../index.php touch FIRST_INSTALL mkdir typo3conf/system/ -p cat > typo3conf/system/additional.php <<- EOF <?php \$GLOBALS['TYPO3_CONF_VARS']['BE']['entryPoint'] = 'admin'; \$GLOBALS['TYPO3_CONF_VARS']['DB']['Connections']['Default'] = [ 'charset' => 'utf8', 'driver' => 'pdo_sqlite', 'path' => dirname(__FILE__) . '/cms.sqlite', ]; EOF (sleep 1 && xdg-open http://127.0.0.1:8080/) & php -S 127.0.0.1:8080 -t . -d max_execution_time=240 -d max_input_vars=1500 ``` -
core-ci voted on patch set 9 V +1 04/01/26, 13:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99405
-
Benni Mack commented on patch set 9 CR +2 V +2 04/01/26, 13:41
thanks! -
Benni Mack merged patch set 10 04/01/26, 13:41
-
Garvin Hicking commented on patch set 10 04/01/26, 18:05
Reply
Thats really cool thx for sharing. I wonder where I can note this down to ever find it when I'll definitely need it.
SetupService.php:322