93487[TASK] Update composer.json when downloading extensions from TER
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Simon Schaufelberger +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 3
Files 3
Review log 2025
-
Benni Mack uploaded patch set 1 03/31/26, 09:51
-
Benni Mack uploaded patch set 2 03/31/26, 09:53
-
core-ci voted on patch set 1 V -1 03/31/26, 10:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99247
-
core-ci voted on patch set 2 V +1 03/31/26, 10:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99248
-
Helmut Hummel commented on patch set 2 03/31/26, 10:27
FileHandlingUtility.php:146add JSON_THROW_ON_ERRORFileHandlingUtility.php:148throw an exception here or assume it is an arrayFileHandlingUtility.php:165we might need a bit of more logic here, otherwise this will fail hard for extensions not yet compatible. we should try reading `depends` and `suggests` from ext_emconf and compare with composer.json require/ suggest and trying to make sense of the values. The most complicated case will be when the extension requires other TER extensions to find out their composer name. Goal is to find non extension packages in composer.json and put those in providesPackages then. -
Benni Mack uploaded patch set 3
V +104/01/26, 17:31 -
Benni Mack commented on patch set 3 04/01/26, 17:31
FileHandlingUtility.php:143ReplyDoneFileHandlingUtility.php:146ReplyDoneFileHandlingUtility.php:148ReplyDone -
core-ci voted on patch set 3 V -1 04/01/26, 17:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99421
-
Helmut Hummel commented on patch set 3 04/08/26, 11:29
FileHandlingUtility.php:165Replywill take care to make a suggestion, but need to sort out other things first -
Benni Mack updated the commit message in patch set 4
V -104/22/26, 07:26 -
Benni Mack rebased onto patch set 5 07/20/26, 11:43
-
core-ci voted on patch set 5 V -1 07/20/26, 11:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105026
-
Benni Mack commented on patch set 5 07/20/26, 11:52
FileHandlingUtility.php:165Replyhey, do you have an update here? -
Helmut Hummel commented on patch set 5 07/24/26, 11:54
FileHandlingUtility.php:145also check for $composerJson['extra']['typo3/cms']['version']FileHandlingUtility.php:156better set $composerJson['extra']['typo3/cms']['version'] insteadFileHandlingUtility.php:165Replysince this is a compatibility functionality I think it will suffice to do the following: Iterate over require and suggest and add everything that is not \TYPO3\CMS\Core\Package\PackageManager::isFrameworkPackage and not \TYPO3\CMS\Core\Package\PackageManager::isComposerDependency to be 100% correct, we could only check it is not a know composer dependency and check with packagist.org API whether the package is not of type typo3-cms-extension and then add it to provides, because this means, that it must not be respected for dependency ordering -
Benni Mack uploaded patch set 6
V -107/24/26, 12:30 -
Benni Mack commented on patch set 6 07/24/26, 12:34
FileHandlingUtility.php:145ReplyDoneFileHandlingUtility.php:156ReplyDoneFileHandlingUtility.php:165Replydone, but I also didn't want to introduce the packagist.org API for this change now. -
core-ci voted on patch set 6 V +1 07/24/26, 12:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105311
-
Helmut Hummel commented on patch set 6 07/24/26, 12:53
FileHandlingUtility.php:172looks good to me now. worst thing that can happen here, is that we add a typo3 extension here, which then will be ignored for depdendency ordering. this can and should be fixed by the extension owner though by providing this piece of information -
Benni Mack marked it ready for review 07/24/26, 12:56
-
Oliver Klee voted on patch set 6 V +1 07/27/26, 07:50
-
Stefan Bürk voted on patch set 6 CR +1 07/27/26, 13:26
-
Stefan Bürk voted on patch set 6 V +1 07/27/26, 13:33
-
Simon Schaufelberger voted on patch set 6 CR +1 V +1 08/02/26, 23:26
-
Stefan Bürk commented on patch set 6 CR +2 V +2 09/02/26, 13:47
FileHandlingUtility.php:172ReplyDone -
Stefan Bürk merged patch set 7 09/02/26, 17:49
FileHandlingUtility.php:143