Review main Merged

93491[TASK] Allow public folder in classic mode

Helmut Hummel CR +2 V +2 Normal +51 −41 updated 04/22/26, 15:47

Commit message

Clarify some of the API usages by using the correct ones
(like projectPath instead of publicPath) and
make some adjustments to classic mode only
paths so that they are located in a more logical
place, when the project folder is not in the document root.

Also remove unnecessary Composer mode checks.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1

Issues 1

Files 11

Review log 2440

Show 815 earlier messages
  1. Helmut Hummel uploaded patch set 1 03/31/26, 11:39

  2. Helmut Hummel marked it work in progress 03/31/26, 11:39

  3. core-ci voted on patch set 1 V +1 03/31/26, 12:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99256

  4. Helmut Hummel uploaded patch set 2 V +1 04/01/26, 11:05

  5. core-ci voted on patch set 2 V +1 04/01/26, 11:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99394

  6. Helmut Hummel uploaded patch set 3 V +1 04/02/26, 10:25

  7. core-ci voted on patch set 3 V +1 04/02/26, 10:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99470

  8. Helmut Hummel updated the commit message in patch set 4 V +1 04/02/26, 11:52

  9. core-ci voted on patch set 4 V +1 04/02/26, 12:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99478

  10. Helmut Hummel rebased onto patch set 5 V +1 04/14/26, 10:10

  11. core-ci voted on patch set 5 V -1 04/14/26, 10:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100132

  12. Helmut Hummel rebased onto patch set 6 V -1 04/14/26, 10:36

  13. core-ci voted on patch set 6 V -1 04/14/26, 10:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100141

  14. Helmut Hummel rebased onto patch set 7 V -1 04/14/26, 11:04

  15. core-ci voted on patch set 7 V -1 04/14/26, 11:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100152

  1. Helmut Hummel rebased onto patch set 8 V -1 04/14/26, 12:52

  2. core-ci voted on patch set 8 V -1 04/14/26, 13:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100158

  3. Helmut Hummel rebased onto patch set 9 V -1 04/14/26, 13:15

  4. core-ci voted on patch set 9 V -1 04/14/26, 13:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100164

  5. Helmut Hummel rebased onto patch set 10 V -1 04/14/26, 17:18

  6. core-ci voted on patch set 10 V -1 04/14/26, 17:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100181

  7. core-ci commented on patch set 10 04/14/26, 20:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100181

  8. Helmut Hummel rebased onto patch set 11 V -1 04/14/26, 21:39

  9. Helmut Hummel rebased onto patch set 12 04/14/26, 21:44

  10. Helmut Hummel marked it ready for review 04/14/26, 21:44

  11. core-ci voted on patch set 12 V +1 04/14/26, 21:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100208

  12. core-ci voted on patch set 11 V +1 04/14/26, 22:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100207

  13. Benni Mack voted on patch set 12 CR +1 04/15/26, 05:36

  14. Helmut Hummel uploaded patch set 13 CR +1 V +1 04/16/26, 08:33

  15. Helmut Hummel uploaded patch set 14 04/16/26, 08:35

  16. core-ci voted on patch set 13 V +1 04/16/26, 08:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100301

  17. core-ci voted on patch set 14 V +1 04/16/26, 08:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100303

  18. Benni Mack updated the commit message in patch set 15 V +1 04/21/26, 11:52

  19. Benni Mack voted on patch set 15 CR +1 V +1 04/21/26, 11:52

  20. core-ci voted on patch set 15 V +1 04/21/26, 12:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100638

  21. Benni Mack updated the commit message in patch set 16 CR +1 V +1 04/22/26, 07:26

  22. Benni Mack voted on patch set 16 CR +1 V +1 04/22/26, 10:38

  23. Oliver Klee voted on patch set 16 CR +1 V +1 04/22/26, 10:50

  24. Benni Mack voted on patch set 16 CR +2 V +2 04/22/26, 15:47

  25. Benni Mack merged patch set 17 04/22/26, 15:47