Review main Merged

93496[TASK] Clarify Fluid analyze command

Simon Praetorius CR +2 V +2 Easy +18 −14 updated 03/31/26, 17:29

Commit message

The fluid:analyze CLI command now clarifies that only `*.fluid.*`
files are analyzed.

Also, the default command name is changed from `analyse` (BE, like
phpstan named it) to `analyze` (AE).

Review

  • Code review CR +2 Done
    • Simon Praetorius +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Guido Schmechel +1
  • Verified V +2 Done
    • Simon Praetorius +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Guido Schmechel +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1114

  1. Simon Praetorius uploaded patch set 1 03/31/26, 14:19

  2. Simon Praetorius uploaded patch set 2 03/31/26, 14:21

  3. Simon Praetorius uploaded patch set 3 03/31/26, 14:29

  4. core-ci voted on patch set 2 V +1 03/31/26, 14:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99287

  5. Garvin Hicking commented on patch set 3 CR +1 V +1 03/31/26, 14:42

    I'm zad.
  6. core-ci voted on patch set 3 V +1 03/31/26, 14:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99288

  7. core-ci voted on patch set 1 V +1 03/31/26, 14:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99285

  8. Guido Schmechel commented on patch set 3 03/31/26, 15:08

    Feature-108763-ConsoleCommandToAnalyseFluidTemplates.rst:1

    Feature-108763-ConsoleCommandToAnalyzeFluidTemplates.rst vs Feature-108763-ConsoleCommandToAnalyseFluidTemplates.rst
  9. Simon Praetorius commented on patch set 3 03/31/26, 15:14

    Feature-108763-ConsoleCommandToAnalyseFluidTemplates.rst:1 Reply

    I didn't want to change that to avoid breaking links. I think it's fine in the filename.
  10. Oliver Klee voted on patch set 3 CR +1 V +1 03/31/26, 15:22

  11. Guido Schmechel voted on patch set 3 CR +1 V +1 03/31/26, 15:23

  12. Guido Schmechel commented on patch set 3 03/31/26, 15:23

    Feature-108763-ConsoleCommandToAnalyseFluidTemplates.rst:1 Reply

    Done
  13. Simon Praetorius voted on patch set 3 CR +2 V +2 03/31/26, 17:29

  14. Simon Praetorius merged patch set 4 03/31/26, 17:29