Review main Merged

93497[TASK] Add accent color harmonization

Benjamin Kott CR +2 V +2 Normal +40 −25 updated 04/02/26, 16:39

Commit message

Harmonize state colors with the primary accent color to create a more
cohesive color palette. Surface token mappings are adjusted for improved
contrast and additional neutral shade stops are added to support finer
granularity. The classic theme disables harmonization to preserve its
existing appearance, while the fresh theme derives its scaffold and icon
colors from the primary base token using relative color syntax.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1420

  1. Benjamin Kott uploaded patch set 1 03/31/26, 15:34

  2. core-ci voted on patch set 1 V +1 03/31/26, 15:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99293

  3. Benjamin Kott uploaded patch set 2 V +1 04/01/26, 08:51

  4. core-ci voted on patch set 2 V +1 04/01/26, 09:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99372

  5. Benjamin Kott uploaded patch set 3 V +1 04/01/26, 10:12

  6. core-ci voted on patch set 3 V +1 04/01/26, 10:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99386

  7. Benni Mack commented on patch set 3 CR +1 V +1 04/01/26, 13:46

    +1
  8. Benjamin Kott commented on patch set 3 CR -1 04/01/26, 14:17

    discussing surfaces
  9. Benjamin Kott uploaded patch set 4 CR +1 V +1 04/01/26, 14:24

  10. core-ci voted on patch set 4 V +1 04/01/26, 14:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99414

  11. Simon Schaufelberger commented on patch set 4 04/01/26, 18:12

    🧡 I really like the slightly brighter background color in dark mode! In my opinion the background color of the main content is still too dark. There is also a big difference if you are on the Layout module where the content elements have a brighter color than when you open the user settings where the whole page is really dark. I'm not sure about your goals but for me they should have the same color (something close to #25282c)
  12. Benjamin Kott uploaded patch set 5 V +1 04/02/26, 06:03

  13. Benjamin Kott commented on patch set 5 04/02/26, 06:07

    Reply Unresolved

    thx for the feedback, i again tuned the colors here and slightly raised the lowest surface color in darkmode (as i messed up the scaling here and it was a position off). Due to the levels i would prefer to go with the current state, as we need some kind of good distinguishable levels while covering the 5 steps we currently support here. we may need to get too light on the other end otherwise or loose again the separation.
  14. core-ci voted on patch set 5 V -1 04/02/26, 06:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99439

  15. core-ci voted on patch set 5 V +1 04/02/26, 06:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99439

  16. Benjamin Franzke voted on patch set 5 CR +1 V +1 04/02/26, 06:53

  17. Georg Ringer voted on patch set 5 CR +2 V +2 04/02/26, 07:28

  18. Georg Ringer merged patch set 6 04/02/26, 07:28

  19. Ayke Halder commented on patch set 6 04/02/26, 16:15

    Post -1: This does not work in Firefox.
  20. Simon Schaufelberger commented on patch set 6 04/02/26, 16:39

    Reply Unresolved

    I wonder what exactly doesn't work in Firefox. The custom property?