Review main Merged

93508[BUGFIX] Omit opacity attribute on color picker when disabled

Benjamin Kott CR +2 V +2 Easy +3 −1 updated 04/01/26, 10:24

Commit message

Lit's `@property({ type: Boolean })` follows HTML boolean attribute
semantics where the presence of the attribute means `true`, regardless
of its value. Setting `opacity="false"` on the
`<typo3-backend-color-picker>` web component therefore incorrectly
enabled the opacity slider.

The attribute is now only rendered when opacity is actually enabled.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Benjamin Kott uploaded patch set 1 04/01/26, 09:27

  2. Benjamin Franzke voted on patch set 1 CR +1 V +1 04/01/26, 09:33

  3. core-ci voted on patch set 1 V +1 04/01/26, 09:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99378

  4. Andreas Kienast voted on patch set 1 CR +1 V +1 04/01/26, 09:59

  5. Benjamin Kott voted on patch set 1 CR +2 V +2 04/01/26, 10:24

  6. Benjamin Kott merged patch set 2 04/01/26, 10:24