Review main Merged

93510[TASK] Improve form manager list visual indicators and sorting

Benjamin Kott CR +2 V +2 Normal +73 −58 updated 04/02/26, 06:11

Commit message

Show a lock overlay icon on the form icon for read-only forms instead
of a separate badge. Display an "invalid" text badge for forms that
cannot be parsed. Pass normalized order field and direction from
SearchCriteria to the template so the default sorting is correctly
indicated and add missing sortable fields to the allowed list.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Josua Vogel +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Josua Vogel +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 811

  1. Benjamin Kott uploaded patch set 1 04/01/26, 10:54

  2. Benjamin Kott uploaded patch set 2 04/01/26, 10:56

  3. core-ci voted on patch set 2 V +1 04/01/26, 11:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99393

  4. core-ci voted on patch set 1 V +1 04/01/26, 11:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99392

  5. Josua Vogel commented on patch set 2 V -1 04/01/26, 12:41

    on it, sorting doesn´t work
  6. Josua Vogel uploaded patch set 3 V +1 04/01/26, 12:43

  7. Josua Vogel voted on patch set 3 CR +1 V +1 04/01/26, 12:43

  8. core-ci voted on patch set 3 V +1 04/01/26, 12:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99400

  9. Simon Schaufelberger voted on patch set 3 CR +1 V +1 04/01/26, 18:15

  10. Benjamin Kott voted on patch set 3 CR +2 V +2 04/02/26, 06:11

  11. Benjamin Kott merged patch set 4 04/02/26, 06:11