93513[BUGFIX] First install: display password-toggle icon within field
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Benjamin Kott +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Benjamin Kott +1
- core-ci +1 CI
Issues 1
Files 1
Review log 78
-
Markus Klein uploaded patch set 1 04/01/26, 13:58
-
core-ci voted on patch set 1 V +1 04/01/26, 14:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99410
-
Benni Mack commented on patch set 1 04/01/26, 14:46
I assume we won't do inline styles due to CSP? -
Markus Klein commented on patch set 1 04/01/26, 15:33
Reply
I didn't change anything in this regard. This was inline CSS already. :-) -
Benjamin Franzke commented on patch set 1 CR +1 V +1 04/02/26, 11:40
Reply
There is no known vulnerability with `style-src-attr` (opposed to `style-src-elem` which can introspect user state via workarounds), which is why we generally allow inline css. Fine for now to fix this glitch. -
Benjamin Kott voted on patch set 1 CR +1 V +1 04/02/26, 11:40
-
Benjamin Franzke voted on patch set 1 CR +2 V +2 04/02/26, 11:40
-
Benjamin Franzke merged patch set 2 04/02/26, 11:40