Review main Merged

93516[BUGFIX] Fix persistent update for checkbox fields in user settings

Benni Mack CR +2 V +2 Normal +61 −1 updated 04/03/26, 08:16

Commit message

Since the migration to FormEngine, checkbox fields with
persistentUpdate flag (e.g. showWorkspaceLiveIndicator) could
no longer be disabled in the User Settings.

FormEngine always submits a hidden field for checkboxes, even
when unchecked (with value "0"). The persistent update logic
used isset() to detect checkbox state, which always returned
true. This caused the AJAX persistent update callback to
overwrite the correctly saved value back to "1" in the database.

Note: AI kickstarted the e2e test.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • Josua Vogel +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • Josua Vogel +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 710

  1. Benni Mack uploaded patch set 1 04/01/26, 17:26

  2. core-ci voted on patch set 1 V -1 04/01/26, 17:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99420

  3. Benni Mack rebased onto patch set 2 V -1 04/02/26, 09:16

  4. core-ci voted on patch set 2 V -1 04/02/26, 09:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99460

  5. Benni Mack uploaded patch set 3 V -1 04/02/26, 20:17

  6. core-ci voted on patch set 3 V +1 04/02/26, 20:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99523

  7. Josua Vogel voted on patch set 3 CR +1 V +1 04/03/26, 06:36

  8. Garvin Hicking voted on patch set 3 CR +1 V +1 04/03/26, 07:13

  9. Georg Ringer voted on patch set 3 CR +2 V +2 04/03/26, 08:16

  10. Georg Ringer merged patch set 4 04/03/26, 08:16