Review main Merged

93520[BUGFIX] Fix exception on multi-upload form resubmission

Josua Vogel CR +2 V +2 Normal +94 −4 updated 04/13/26, 15:46

Commit message

PropertyMappingConfiguration::adjustPropertyMappingForFileUploadsAtRuntime()
now sets the data type to ObjectStorage when the multiple property
is enabled. This is the correct lifecycle point because YAML-defined
properties are guaranteed to be available here, unlike in
initializeFormElement() which runs before they are set.

Additionally, UploadedResourceViewHelper::getUploadedResource() now wraps
a single FileReference in an ObjectStorage when multiple=true is set.
This acts as a defensive safety net for stale session data that may still
contain a single FileReference for a multi-upload field.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Sven Liebert +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Sven Liebert +1
    • Tung Ngo +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 67

  1. Josua Vogel uploaded patch set 1 04/02/26, 08:42

  2. core-ci voted on patch set 1 V +1 04/02/26, 08:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99458

  3. Garvin Hicking commented on patch set 1 CR +1 04/02/26, 09:43

    Looks good from a code-read perspective. Could not verify yet though, and likely will not be able to do until after easter holiday. If anyone can verify, I'm good to merge 😊
  4. Tung Ngo voted on patch set 1 V +1 04/02/26, 14:33

  5. Sven Liebert voted on patch set 1 CR +1 V +1 04/09/26, 09:48

  6. Garvin Hicking voted on patch set 1 CR +2 V +2 04/13/26, 15:46

  7. Garvin Hicking merged patch set 2 04/13/26, 15:46