Review main Merged

93521[BUGFIX] Allow to bookmark and share filters in EXT:redirects overviews

Benjamin Franzke CR +2 V +2 Normal +54 −36 updated 09/15/26, 13:43

Commit message

Calculate a minimal set of parameters to allow the boomark and
shareable URL feature to pickup the current view restrictions.

Also redirect the POST action to a GET route with the same
set of parameters to allow reloading the backend without losing
current view restrictions.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Lisa Kreitz +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Lisa Kreitz +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1115

  1. Benjamin Franzke uploaded patch set 1 04/02/26, 09:22

  2. Benjamin Franzke voted on patch set 1 CR -1 04/02/26, 09:24

  3. core-ci voted on patch set 1 V -1 04/02/26, 09:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99461

  4. Benjamin Franzke uploaded patch set 2 CR -1 V -1 04/02/26, 09:38

  5. Benjamin Franzke uploaded patch set 3 04/02/26, 09:42

  6. Benjamin Franzke updated the commit message in patch set 4 04/02/26, 09:43

  7. core-ci voted on patch set 2 V -1 04/02/26, 09:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99463

  8. core-ci voted on patch set 3 V +1 04/02/26, 09:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99464

  9. core-ci voted on patch set 4 V +1 04/02/26, 09:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99465

  10. Lisa Kreitz commented on patch set 4 CR +1 V +1 04/15/26, 10:39

    works for me in v14.
  11. Benni Mack voted on patch set 4 CR +1 V +1 04/17/26, 11:47

  12. Georg Ringer commented on patch set 4 04/17/26, 13:55

    I am not so sure about that. So why do we need to fix that here but e.g. not in record module or log module? there are filters everywhere which are not part of the bookmarks. don't we need to have one solution for everywhere and maybe have a toggle adding bookmarks to ask editors if with filter or without? don't know but changing to just with filters is IMO not the correct solution
  13. Benjamin Franzke commented on patch set 4 06/30/26, 09:26

    Reply

    Hey, I'm fine to apply the same to other modules. I just went through some forge issues and wanted to fix this explicitly reported case https://forge.typo3.org/issues/103830 We can open issues for other modules as well, fine by me. I personally do not think bookmarking should ask the user whether to include filters, because that's the intention of a bookmark: to persist the context, but feel free to -1 to make clear if you are against merging current state. Thanks!
  14. Benjamin Franzke commented on patch set 4 CR +2 V +2 09/15/26, 13:43

    Reply

    Hey, I hope its fine that I'm going to merge this now, since you didn't raise a veto. Thanks!
  15. Benjamin Franzke merged patch set 5 09/15/26, 13:43