93522[TASK] Improve language selector labels for root-level records
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Garvin Hicking +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 7
- Build/Sources/Sass/component/_module.scss+8 −0
- typo3/sysext/backend/Classes/Configuration/TranslationConfigurationProvider.php10+41 −23
- typo3/sysext/backend/Resources/Private/Partials/DocHeader.fluid.html+1 −1
- typo3/sysext/backend/Resources/Public/Css/backend.css+2 −1
- typo3/sysext/backend/Tests/Unit/Configuration/TranslationConfigurationProviderTest.php+140 −38
- typo3/sysext/core/Resources/Private/Language/locallang_general.xlf+3 −0
- typo3/sysext/install/Resources/Private/Templates/Layout/MainLayout.fluid.html+1 −1
Review log 1923
-
Benjamin Kott uploaded patch set 1 04/02/26, 11:11
-
core-ci voted on patch set 1 V +1 04/02/26, 11:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99472
-
Benjamin Franzke uploaded patch set 2
V +104/02/26, 12:31 -
core-ci voted on patch set 2 V +1 04/02/26, 12:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99482
-
Ayke Halder commented on patch set 2 CR -1 04/07/26, 15:39
-
Ayke Halder commented on patch set 2 04/07/26, 15:50
TranslationConfigurationProvider.php:81Implement this outside `foreach` loop: ``` if (isset($allSystemLanguages[0] && count($allSystemLanguages[0]['knownTitles'] ?? []) > 1) { /* Code for language-id 0 */ … } ```TranslationConfigurationProvider.php:123Implement `'knownTitles'` outside `foreach` loop and for language id 0 only. -
Ayke Halder commented on patch set 2 04/07/26, 16:11
TranslationConfigurationProvider.php:83`flagIcon` logic can be removed here as it is already set in `addSiteLanguagesToConsolidatedList` if there are multiple `'knownTitles'`. Or as alternative: * remove `'title'` and logic for `…['flagIcon'] = 'flags-multiple'` from `addSiteLanguagesToConsolidatedList` * add `'title'` generation here via `$language['title'] = implode(',' , array_keys($language['knownTitles']);` * add `'flags-multiple'` here via `if (count($language['knownTitles']) > 1) { $language['flagIcon'] = 'flags-multiple'; }` . -
Ayke Halder commented on patch set 2 04/07/26, 16:14
TranslationConfigurationProvider.php:75The argument `$allSystemLanguages` can be provided as reference to `addSiteLanguagesToConsolidatedList()`. -
Ayke Halder commented on patch set 2 04/07/26, 17:13
@benjamin.kott@outlook.com Please have a look, if this would be fine for you: https://review.typo3.org/c/Packages/TYPO3.CMS/+/93556/2/typo3/sysext/backend/Classes/Configuration/TranslationConfigurationProvider.php -
Ayke Halder commented on patch set 2 04/08/26, 09:17
-
Benjamin Kott commented on patch set 2 04/08/26, 11:55
Reply
its impossible to review the changes in that state, please push a new patchset on this change so we can compare the changes and see what actually has changed. -
Ayke Halder uploaded patch set 3
CR +1V +104/08/26, 12:53 -
Ayke Halder commented on patch set 3 04/08/26, 12:55
Reply
TranslationConfigurationProvider.php:75ReplyDoneTranslationConfigurationProvider.php:81ReplyDoneTranslationConfigurationProvider.php:83ReplyDoneTranslationConfigurationProvider.php:123ReplyDoneTranslationConfigurationProvider.php:126ReplyDone -
core-ci voted on patch set 3 V +1 04/08/26, 13:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99764
-
Ayke Halder uploaded patch set 4
V +104/08/26, 13:12 -
Ayke Halder commented on patch set 4 04/08/26, 13:14
Reply
New diff for small update: https://review.typo3.org/c/Packages/TYPO3.CMS/+/93522/2..4 -
core-ci voted on patch set 4 V +1 04/08/26, 13:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99768
-
Benjamin Kott commented on patch set 4 04/08/26, 13:59
Reply
all fine for me, do not really care about the php part - only the result is important -
Garvin Hicking commented on patch set 4 04/08/26, 19:29
I can verify this already optimizes the display in the breadcrumb and also the record listing. However, in the FormEngine TCA edit view the "sys_language_uid" dropdown for me still shows a huge list of all languages instead of "Default" as the first one. I've attached two screenshots for this in the issue (and two that show how it 'properly' renders the record table for me). Is this beyond scope of this patch or a lurking follow-up issue? -
Benjamin Kott commented on patch set 4 04/08/26, 20:08
Reply
actually, my only goal was to fix the behavior of the document header bar - this was just a nesessitiy -
Garvin Hicking commented on patch set 4 CR +1 V +1 04/08/26, 20:18
Reply
Acknowledged -
Benjamin Franzke voted on patch set 4 CR +2 V +2 04/09/26, 07:12
-
Benjamin Franzke merged patch set 5 04/09/26, 07:13
TranslationConfigurationProvider.php:126