Review main Abandoned

93526[BUGFIX] Bind validation overlay focus to triggering element

Christian Jung CR 0 V +1 Easy +7 −1 updated 11/11/26, 10:36

Commit message

When editing a page in the backend and clearing a required field,
 an overlay (e.g. validation) is displayed.
After closing the overlay, focus returns to the element that
 triggered the overlay.

Review

  • Code review CR 0
  • Verified V +1
    • Jennifer Geiß +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 2031

Show 36 earlier messages
  1. Christian Jung uploaded patch set 1 04/02/26, 13:18

  2. core-ci voted on patch set 1 V -1 04/02/26, 13:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99488

  3. Christian Jung updated the commit message in patch set 2 V -1 04/09/26, 12:13

  4. core-ci voted on patch set 2 V +1 04/09/26, 12:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99850

  5. Christian Jung updated the commit message in patch set 3 V +1 04/09/26, 12:25

  6. core-ci voted on patch set 3 V +1 04/09/26, 12:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99851

  1. Benni Mack updated the commit message in patch set 4 V +1 04/22/26, 06:45

  2. core-ci voted on patch set 4 V +1 04/22/26, 11:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100785

  3. Christian Rath-Ulrich updated the commit message in patch set 5 V +1 04/29/26, 10:04

  4. Christian Rath-Ulrich voted on patch set 5 CR +1 V +1 04/29/26, 10:12

  5. core-ci voted on patch set 5 V -1 04/29/26, 10:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101254

  6. Oliver Klee commented on patch set 5 CR -1 04/29/26, 10:52

    The `:` looks lost directly after the `[BUGFIX]`. Is there something missing from the commit message title? (Currently, it's not clear to me from the title which area/functionality is affected. This should be clear from the title, even if the description may elaborate further.)
  7. Christian Jung updated the commit message in patch set 6 CR +1 V +1 04/29/26, 12:20

  8. Christian Rath-Ulrich updated the commit message in patch set 7 04/29/26, 12:26

  9. Christian Rath-Ulrich commented on patch set 7 04/29/26, 12:26

    Reply

    Done
  10. Christian Rath-Ulrich updated the commit message in patch set 8 04/29/26, 12:27

  11. core-ci voted on patch set 8 V +1 04/29/26, 12:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101271

  12. core-ci voted on patch set 6 V +1 04/29/26, 12:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101268

  13. core-ci voted on patch set 7 V +1 04/29/26, 13:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101270

  14. Garvin Hicking commented on patch set 8 04/29/26, 17:31

    Please adhere to commit message guidelines: subject length, uppercase, linebreaks.
  15. Christian Jung updated the commit message in patch set 9 V +1 04/30/26, 06:06

  16. core-ci voted on patch set 9 V +1 04/30/26, 06:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101310

  17. Garvin Hicking commented on patch set 9 04/30/26, 12:16

    Reply Unresolved

    (this is still not right)
  18. Christian Jung updated the commit message in patch set 10 V +1 04/30/26, 12:19

  19. core-ci voted on patch set 10 V -1 04/30/26, 12:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101335

  20. Garvin Hicking commented on patch set 10 04/30/26, 12:56

    Unresolved

    Uppercase "B" here. And commit body must not have leading whitespace after newlines. :) Sorry to be pesty about this, but I want to ensure consistent style.
  21. Christian Jung updated the commit message in patch set 11 V -1 05/12/26, 13:36

  22. core-ci voted on patch set 11 V +1 05/12/26, 13:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101903

  23. Jennifer Geiß voted on patch set 11 V +1 06/17/26, 12:43

  24. Benni Mack commented on patch set 11 11/11/26, 10:36

    Thanks for working on this! In the meantime #108965 was fixed with https://review.typo3.org/c/Packages/TYPO3.CMS/+/96969 (main + 14.3), which restores the focus to the element that opened a modal, including elements inside the module frame (which document.activeElement of the top document alone does not reach). Opening focus and focus trapping are handled by the native <dialog> / showModal(). I'd therefore suggest abandoning this change and closing #108875 as a duplicate of #108965.
  25. Benni Mack abandoned the change 11/11/26, 10:36