93526[BUGFIX] Bind validation overlay focus to triggering element
Commit message
Review
-
Code review CR 0
-
Verified V +1
- Jennifer Geiß +1
- core-ci +1 CI
Issues 1
Files 2
Review log 2031
Show 36 earlier messages
-
Christian Jung uploaded patch set 1 04/02/26, 13:18
-
core-ci voted on patch set 1 V -1 04/02/26, 13:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99488
-
Christian Jung updated the commit message in patch set 2
V -104/09/26, 12:13 -
core-ci voted on patch set 2 V +1 04/09/26, 12:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99850
-
Christian Jung updated the commit message in patch set 3
V +104/09/26, 12:25 -
core-ci voted on patch set 3 V +1 04/09/26, 12:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99851
-
Benni Mack updated the commit message in patch set 4
V +104/22/26, 06:45 -
core-ci voted on patch set 4 V +1 04/22/26, 11:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100785
-
Christian Rath-Ulrich updated the commit message in patch set 5
V +104/29/26, 10:04 -
Christian Rath-Ulrich voted on patch set 5 CR +1 V +1 04/29/26, 10:12
-
core-ci voted on patch set 5 V -1 04/29/26, 10:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101254
-
Oliver Klee commented on patch set 5 CR -1 04/29/26, 10:52
The `:` looks lost directly after the `[BUGFIX]`. Is there something missing from the commit message title? (Currently, it's not clear to me from the title which area/functionality is affected. This should be clear from the title, even if the description may elaborate further.) -
Christian Jung updated the commit message in patch set 6
CR +1V +104/29/26, 12:20 -
Christian Rath-Ulrich updated the commit message in patch set 7 04/29/26, 12:26
-
Christian Rath-Ulrich commented on patch set 7 04/29/26, 12:26
Reply
Done -
Christian Rath-Ulrich updated the commit message in patch set 8 04/29/26, 12:27
-
core-ci voted on patch set 8 V +1 04/29/26, 12:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101271
-
core-ci voted on patch set 6 V +1 04/29/26, 12:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101268
-
core-ci voted on patch set 7 V +1 04/29/26, 13:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101270
-
Garvin Hicking commented on patch set 8 04/29/26, 17:31
Please adhere to commit message guidelines: subject length, uppercase, linebreaks. -
Christian Jung updated the commit message in patch set 9
V +104/30/26, 06:06 -
core-ci voted on patch set 9 V +1 04/30/26, 06:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101310
-
Garvin Hicking commented on patch set 9 04/30/26, 12:16
Reply Unresolved
(this is still not right) -
Christian Jung updated the commit message in patch set 10
V +104/30/26, 12:19 -
core-ci voted on patch set 10 V -1 04/30/26, 12:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101335
-
Garvin Hicking commented on patch set 10 04/30/26, 12:56
Unresolved
Uppercase "B" here. And commit body must not have leading whitespace after newlines. :) Sorry to be pesty about this, but I want to ensure consistent style. -
Christian Jung updated the commit message in patch set 11
V -105/12/26, 13:36 -
core-ci voted on patch set 11 V +1 05/12/26, 13:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101903
-
Jennifer Geiß voted on patch set 11 V +1 06/17/26, 12:43
-
Benni Mack commented on patch set 11 11/11/26, 10:36
Thanks for working on this! In the meantime #108965 was fixed with https://review.typo3.org/c/Packages/TYPO3.CMS/+/96969 (main + 14.3), which restores the focus to the element that opened a modal, including elements inside the module frame (which document.activeElement of the top document alone does not reach). Opening focus and focus trapping are handled by the native <dialog> / showModal(). I'd therefore suggest abandoning this change and closing #108875 as a duplicate of #108965. -
Benni Mack abandoned the change 11/11/26, 10:36