Review main Merged

93530[BUGFIX] Avoid `Undefined property: stdClass::$version` warning

Stefan Bürk CR +2 V +2 Easy +1 −1 updated 04/02/26, 20:56

Commit message

With [1] resolving #108345 #96388 extension need to have
`version` set in the extension `composer.json` for classic
mode installation.

In case the optional `version` key is not set, which is
recommended to avoid by composer, this leads to a native
php warning:

  Undefined property: stdClass::$version in
  vendor/typo3/cms-core/Classes/Package/PackageManager.php:939

This has been detected trying to make a extension TYPO3 v14 ready
with v13/v14 dual support and keeping the `ext_emconf.php`, which
emits the warning during functional test execution and should at
least respect that it is optional and possible not available.

Does not fix the fact that the deprecation is still triggered,
which is the topic of another change to discuss and resolve.

Let's make at least the warning to vanish.

[1] https://review.typo3.org/c/Packages/TYPO3.CMS/+/91908

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 3

Files 1

Review log 56

  1. Stefan Bürk uploaded patch set 1 04/02/26, 14:58

  2. core-ci voted on patch set 1 V +1 04/02/26, 15:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99505

  3. Garvin Hicking voted on patch set 1 CR +1 V +1 04/02/26, 15:55

  4. Oliver Klee voted on patch set 1 CR +1 V +1 04/02/26, 15:59

  5. Stefan Bürk voted on patch set 1 CR +2 V +2 04/02/26, 20:56

  6. Stefan Bürk merged patch set 2 04/02/26, 20:56