Review main Abandoned

93531[WIP][BUGFIX] Disarm `ext_emconf.php` deprecation for functional tests

Stefan Bürk CR -2 V 0 Easy +25 −1 updated 04/07/26, 10:10

Commit message

-----------------------------------------------------------------

[ ] Verify this change for extension development using composer
    patches.

[ ] Verify against project functional testing with and without
    this change.

[ ] Modify the original changelog entry to make the caveats and
    enforced requirements for extension devlopment more precise
    and clear to mitigate the **to low risk** sounding of it.

-----------------------------------------------------------------

Casual extension development commonly uses composer to install
development dependencies like the `typo3/testing-framework`,
`phpunit/phpunit` and other tools as quality guards and also
executes functional tests based on `typo3/testing-framework`
based implementation.

That symlinks the root extension into the classic mode instances
including the `ext_emconf.php` file and ending up with failing
tests with the deprecation message introduced with [1]:

  Extension "some_extension_key" is having a ext_emconf.php file,
  which is deprecated. Use composer.json exclusively instead.

This forces extension authors to have a `version` set in the
`composer.json` at any time, something which is

a) not required and enforced for TYPO3 composer mode instances
b) not recommended by `composer` if not really needed.

Having the mixed handling mode is specific for testing purpose
only and enforcing to set and handle not recommended `version`
**can not** and **must not** be the solution to enforce here.

This change provides a first approach to mitigate this only
within the testing context taken from casual and recommended
testing setups and keeps the generic deprecation handling in
place like defined and implemented for #108345 and #96388 [1].

It may be not the best solution, but it is at least a working
solution. Other implementation welcome, but pushed to have it
for the multiple extension development in place and possible
also for project testing (not verified yet).

An alternative approach could be to mitigate this within the
`typo3/testing-framework` by providing `true` as the fourth
argument for `new Package()` calls for the composer package
management allowing the `ext_emconf.php` and silencing it
only in that specific context. Possible the better way to
resolve this issue.

[1] https://review.typo3.org/c/Packages/TYPO3.CMS/+/91908

Review

  • Code review CR -2
    • Helmut Hummel -2
  • Verified V 0
    • core-ci +1 CI

Issues 3

Files 1

Review log 810

  1. Stefan Bürk uploaded patch set 1 04/03/26, 00:21

  2. core-ci voted on patch set 1 V +1 04/03/26, 00:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99526

  3. Stefan Bürk uploaded patch set 2 V +1 04/03/26, 01:34

  4. core-ci voted on patch set 2 V +1 04/03/26, 01:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99530

  5. Helmut Hummel commented on patch set 2 CR -1 04/03/26, 11:06

    I do not think this solves anything to hide the deprecation message conditionally
  6. Helmut Hummel commented on patch set 2 04/03/26, 11:15

    The deprecation message enforces nothing! TYPO3 classic mode enforces a version to be set. End of story. We have multiple options to deal with this requirement: 1. ignore it, liften this requirement and and make EM dependency resolving of EM less useful than it currently is. 2. Keep the ext_emconf.php file forever 3. Introduce a new file to store the version in 4. Store the version in a different field https://review.typo3.org/c/Packages/TYPO3.CMS/+/93536 I personally don't like any of these alternatives, but I could live with 4. (hence I proposed the change)
  7. Helmut Hummel voted on patch set 2 CR -2 04/03/26, 12:33

  8. Stefan Bürk commented on patch set 2 04/07/26, 10:10

    Reply

    Done
  9. Stefan Bürk abandoned the change 04/07/26, 10:10

    in favour of 93536: [TASK] Allow extension version declaration in extra.version | https://review.typo3.org/c/Packages/TYPO3.CMS/+/93536
  10. Stefan Bürk commented on patch set 2 04/07/26, 10:10

    Reply

    Done