Review main Merged

93535[BUGFIX] Remove CSS attr() usage for primary color token

Benjamin Kott CR +2 V +2 Easy +4 −4 updated 04/03/26, 16:50

Commit message

The CSS attr() function with type checking (e.g.
`attr(data-accent type(<color>), <fallback>)`) is not yet fully
supported in Firefox. Replace it with direct color values as a
fallback until browser support improves.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Ayke Halder +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Ayke Halder +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 45

  1. Benjamin Kott uploaded patch set 1 04/03/26, 09:56

  2. core-ci voted on patch set 1 V +1 04/03/26, 10:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99558

  3. Ayke Halder commented on patch set 1 CR +1 V +1 04/03/26, 13:44

    Thx, Firefox looks good now.
  4. Benjamin Franzke voted on patch set 1 CR +2 V +2 04/03/26, 16:50

  5. Benjamin Franzke merged patch set 2 04/03/26, 16:50