93544[BUGFIX] Fix missing padding in CSP reports on small screens
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Benjamin Kott +1
-
Verified V +2 Done
- Garvin Hicking +2
- Benjamin Kott +1
- core-ci +1 CI
Issues 1
Files 4
Review log 1923
-
Ravi Sachaniya uploaded patch set 1 04/06/26, 05:39
-
core-ci voted on patch set 1 V +1 04/06/26, 05:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99643
-
Ravi Sachaniya rebased onto patch set 2
V +104/06/26, 09:19 -
core-ci voted on patch set 2 V +1 04/06/26, 09:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99647
-
Garvin Hicking commented on patch set 2 CR +1 V +1 04/07/26, 08:54
Thanks this seems to work well for me. I can't fully judge the CSS though beyond "it works" ;) -
Ravi Sachaniya commented on patch set 2 04/07/26, 09:31
Reply
Thanks for your review 👍 -
Garvin Hicking commented on patch set 2 04/07/26, 17:30
Reply
Done -
Sven Liebert voted on patch set 2 CR +1 V +1 04/08/26, 08:21
-
Georg Ringer commented on patch set 2 CR -1 04/08/26, 09:04
please wait for bkott for final vote -
Josua Vogel commented on patch set 2 04/08/26, 09:08
typo3-backend-security-csp-reports.scss:8The grid-template: "." "." declaration seems unnecessary here. Since no named grid areas are used at this breakpoint, grid-template-columns: minmax(0, 1fr) alone is sufficient — rows will be created implicitly via grid-auto-rows: auto (the default). -
Ravi Sachaniya commented on patch set 2 04/08/26, 09:15
typo3-backend-security-csp-reports.scss:8Replywithout `grid-template-areas` the gap is not applying -
Garvin Hicking rebased onto patch set 3
CR +1V +104/08/26, 18:35 -
Garvin Hicking commented on patch set 3 CR +1 V +1 04/08/26, 18:36
Sorry, I pushed a patch with this relation chain, that was acciddently and needs to be ignored :( -
core-ci voted on patch set 3 V +1 04/08/26, 18:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99789
-
Garvin Hicking commented on patch set 3 04/13/26, 15:14
This might get obsolete with https://review.typo3.org/c/Packages/TYPO3.CMS/+/93066 - could you check if the patch from Benni fixes this? -
Ravi Sachaniya commented on patch set 3 04/14/26, 04:53
Reply
I checked and verified, https://review.typo3.org/c/Packages/TYPO3.CMS/+/93066 using this patch the spacing issue is not resolved as mentioned here: https://forge.typo3.org/issues/109491 checked in both modules - 1) Site Setup module CSP report and - 2) Reports module -
Garvin Hicking commented on patch set 3 04/14/26, 05:15
Ok thx. Then as Georg said I hope @benjamin.kott@outlook.com can chime in. -
Garvin Hicking commented on patch set 3 04/14/26, 05:15
Reply
Done -
Benjamin Kott uploaded patch set 4
CR +1V +104/20/26, 15:21 -
Benjamin Kott commented on patch set 4 CR +1 V +1 04/20/26, 15:21
typo3-backend-security-csp-reports.scss:8ReplyDone -
core-ci voted on patch set 4 V +1 04/20/26, 15:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100576
-
Garvin Hicking voted on patch set 4 CR +2 V +2 04/20/26, 16:15
-
Garvin Hicking merged patch set 5 04/20/26, 16:15