93546[BUGFIX] Fix severity handling in infobox About Module
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Garvin Hicking +1
-
Verified V +2 Done
- Benni Mack +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 3
Review log 2635
Show 810 earlier messages
-
Ravi Sachaniya uploaded patch set 1 04/06/26, 10:34
-
core-ci voted on patch set 1 V +1 04/06/26, 10:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99649
-
Josua Vogel voted on patch set 1 CR +1 V +1 04/06/26, 14:08
-
Andreas Kienast updated the commit message in patch set 2
CR +1V +104/07/26, 04:51 -
Andreas Kienast voted on patch set 2 CR +1 04/07/26, 04:51
-
core-ci voted on patch set 2 V +1 04/07/26, 05:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99664
-
Josef Glatz voted on patch set 2 CR -1 04/07/26, 05:15
-
Josef Glatz updated the commit message in patch set 3
CR +1V +104/07/26, 05:16 -
Josef Glatz voted on patch set 3 CR +1 V +1 04/07/26, 05:16
-
Andreas Kienast voted on patch set 3 CR +1 04/07/26, 05:19
-
core-ci voted on patch set 3 V +1 04/07/26, 05:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99667
-
Josua Vogel voted on patch set 3 CR +1 V +1 04/07/26, 05:38
-
Garvin Hicking commented on patch set 3 CR -1 V -1 04/07/26, 09:05
With this change the current flash message is now shown as "OK". Because in `typo3/sysext/reports/Classes/Report/WarningsForAboutModule.php` the Flashmessage is contstructed without severity. So all event listeners would need to be adjusted to have the proper state now. -
Josef Glatz voted on patch set 3 CR 0 V 0 04/07/26, 09:18
-
Ravi Sachaniya commented on patch set 3 04/07/26, 09:19
Reply
Acknowledged -
Ravi Sachaniya uploaded patch set 4
CR +1V +104/07/26, 09:29 -
Garvin Hicking commented on patch set 4 04/07/26, 09:36
So let me circle back on this. The intention of this fix is to allow non-error messages in the "About module", right? Before, the hardcoding ensured that all messages were displayed as errors. If 3rd party event listeners also simply used "any message" and know it would be rendered as an error, this is now a change in behaviour because the default is "green - all good". So I think we have three options: 1. Add an "Important.rst" file that informs about event listeners will need to always provide a severity now 2. Do not perform this bugfix and leave everything at "error only" 3. Create a new kind of FlashMessage that defaults to "error" instead of "OK", and utilize that one for the message outputs. Then, event listeners can provide the "OK" state intentionally. This solution has considerable overhead of course. I must admit, I'm unsure about this and would like to hear some feedback. -
core-ci voted on patch set 4 V +1 04/07/26, 09:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99687
-
Ravi Sachaniya commented on patch set 4 04/07/26, 09:54
Reply
Thanks for laying this out so clearly — this is a really helpful breakdown I agree changing the default to “OK” could break existing behavior silently for 3rd party event listeners Would love to hear others’ thoughts on this -
Lina Wolf commented on patch set 4 04/07/26, 11:30
Reply
I would argue that the default of the constructor is not beeing changed, it has always been OK. The only thing beeing fixed is that the message is displayed with its designated state. -
Garvin Hicking uploaded patch set 5
V +104/08/26, 18:35 -
Garvin Hicking uploaded patch set 6 04/08/26, 18:39
-
Garvin Hicking commented on patch set 6 04/08/26, 18:40
Reply
(Sorry, I accidentally pushed over this patch. I reverted the change) @Lina - it has never been "OK" before. This output was always only meant to contain errors, not success messages. Thus, we cannot argue with constructor defaults, but with original intent to only display errors. -
core-ci voted on patch set 5 V +1 04/08/26, 19:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99790
-
core-ci voted on patch set 6 V +1 04/08/26, 19:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99792
-
Benni Mack updated the commit message in patch set 7
V +104/22/26, 06:45 -
core-ci voted on patch set 7 V +1 04/22/26, 11:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100784
-
Georg Ringer uploaded patch set 8
V +109/09/26, 16:15 -
Georg Ringer uploaded patch set 9 09/09/26, 16:17
-
core-ci voted on patch set 8 V +1 09/09/26, 16:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108206
-
core-ci voted on patch set 9 V +1 09/09/26, 16:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108207
-
Benni Mack voted on patch set 9 CR +1 V +1 09/15/26, 10:33
-
Garvin Hicking commented on patch set 9 CR +1 V +1 09/15/26, 10:36
Reply
Done -
Benni Mack voted on patch set 9 CR +2 V +2 09/15/26, 10:44
-
Benni Mack merged patch set 10 09/15/26, 10:44