93551[TASK] Avoid reloading on visibility-toggle of content element
Commit message
Review
-
Code review CR +2 Done
- Benjamin Kott +2
- Simon Schaufelberger +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Kott +2
- Simon Schaufelberger +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 11
- Build/Sources/TypeScript/backend/layout-module/page-layout-event.tsnew+22 −0
- Build/Sources/TypeScript/backend/layout-module/page-layout.tsnew+102 −0
- Build/Sources/TypeScript/backend/layout-module/toggle-hidden-element.tsnew+126 −0
- Build/Sources/TypeScript/backend/page-actions.tsdeleted+0 −91
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php+9 −15
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/RecordDefault/Header.fluid.html+6 −3
- typo3/sysext/backend/Resources/Private/Templates/PageLayout/PageModule.fluid.html+1 −0
- typo3/sysext/backend/Resources/Public/JavaScript/layout-module/page-layout-event.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/layout-module/page-layout.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/layout-module/toggle-hidden-element.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/page-actions.jsdeleted+0 −13
Review log 1013
-
Benjamin Kott uploaded patch set 1 04/07/26, 12:45
-
Benjamin Kott updated the commit message in patch set 2 04/07/26, 12:50
-
core-ci voted on patch set 1 V +1 04/07/26, 12:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99696
-
core-ci voted on patch set 2 V +1 04/07/26, 13:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99697
-
Simon Schaufelberger commented on patch set 2 04/07/26, 14:52
When you disable the setting "show hidden content elements" and hide a content element, what would you expect to happen? toggle the state or hide it completely afterwards? -
Josef Glatz commented on patch set 2 04/07/26, 17:17
why not working on existing https://review.typo3.org/c/Packages/TYPO3.CMS/+/91888 ? -
Benjamin Kott uploaded patch set 3
V +104/08/26, 08:03 -
Benjamin Kott commented on patch set 3 04/08/26, 08:04
Reply
good catch, yes i would expect to behave exactly the same as the reload - adjusted the patch to match the behavior. -
core-ci voted on patch set 3 V +1 04/08/26, 08:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99741
-
Simon Schaufelberger voted on patch set 3 CR +1 V +1 04/08/26, 09:58
-
Benni Mack voted on patch set 3 CR +1 V +1 04/08/26, 12:46
-
Benjamin Kott voted on patch set 3 CR +2 V +2 04/08/26, 13:55
-
Benjamin Kott merged patch set 4 04/08/26, 13:55