Review main Merged

93551[TASK] Avoid reloading on visibility-toggle of content element

Benjamin Kott CR +2 V +2 Hard +305 −122 updated 04/08/26, 13:55

Commit message

The visibility toggle button for content elements in the page module
previously navigated to tce_db causing a full page reload. This is
replaced with an AJAX call to the existing record_toggle_visibility
route, updating the icon, hidden state classes, and toolbar counter
inline without reloading the page.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Simon Schaufelberger +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Simon Schaufelberger +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 1013

  1. Benjamin Kott uploaded patch set 1 04/07/26, 12:45

  2. Benjamin Kott updated the commit message in patch set 2 04/07/26, 12:50

  3. core-ci voted on patch set 1 V +1 04/07/26, 12:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99696

  4. core-ci voted on patch set 2 V +1 04/07/26, 13:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99697

  5. Simon Schaufelberger commented on patch set 2 04/07/26, 14:52

    When you disable the setting "show hidden content elements" and hide a content element, what would you expect to happen? toggle the state or hide it completely afterwards?
  6. Josef Glatz commented on patch set 2 04/07/26, 17:17

  7. Benjamin Kott uploaded patch set 3 V +1 04/08/26, 08:03

  8. Benjamin Kott commented on patch set 3 04/08/26, 08:04

    Reply

    good catch, yes i would expect to behave exactly the same as the reload - adjusted the patch to match the behavior.
  9. core-ci voted on patch set 3 V +1 04/08/26, 08:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99741

  10. Simon Schaufelberger voted on patch set 3 CR +1 V +1 04/08/26, 09:58

  11. Benni Mack voted on patch set 3 CR +1 V +1 04/08/26, 12:46

  12. Benjamin Kott voted on patch set 3 CR +2 V +2 04/08/26, 13:55

  13. Benjamin Kott merged patch set 4 04/08/26, 13:55