Review main Abandoned

93553[BUGFIX] Return focus to edit icon after page title editing

Christian Jung CR 0 V -1 Easy +4 −2 updated 05/20/26, 09:52

Commit message

In the “Page,List” module (in v14: layout and record module),
the page title can be edited inline via the pencil icon next
to the page heading.

Ensure that the interface is not losing visible keyboard focus
after finishing the edit (save or cancel) by returning
the focus to triggering pencil icon.
This improve keyboard operation and positively affects accessibility.

Review

  • Code review CR 0
  • Verified V -1
    • Benjamin Franzke -1
    • core-ci -1 CI

Issues 1

Files 2

Review log 1120

  1. Christian Jung uploaded patch set 1 04/07/26, 14:32

  2. core-ci voted on patch set 1 V -1 04/07/26, 14:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99704

  3. core-ci voted on patch set 1 V +1 04/07/26, 19:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99704

  4. Christian Jung uploaded patch set 2 V +1 04/09/26, 12:09

  5. core-ci voted on patch set 2 V -1 04/09/26, 12:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99849

  6. Christian Jung updated the commit message in patch set 3 V -1 04/09/26, 12:30

  7. core-ci voted on patch set 3 V -1 04/09/26, 12:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99852

  8. Christian Jung updated the commit message in patch set 4 V -1 04/13/26, 10:57

  9. core-ci voted on patch set 4 V -1 04/13/26, 11:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100071

  10. Julian Seiler voted on patch set 4 CR +1 V +1 04/14/26, 22:15

  11. Benni Mack updated the commit message in patch set 5 CR +1 V +1 04/22/26, 06:47

  12. core-ci voted on patch set 5 V -1 04/22/26, 11:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100800

  13. Christian Rath-Ulrich uploaded patch set 6 V -1 04/27/26, 10:53

  14. core-ci voted on patch set 6 V +1 04/27/26, 11:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101162

  15. Benjamin Franzke rebased onto patch set 7 V +1 04/28/26, 07:08

  16. Benjamin Franzke commented on patch set 7 V -1 04/28/26, 07:11

    editable-page-title.ts:218 Unresolved

    For (unknown) reasons this does not suffice for me, it requires another setTimeout with some milliseconds to work. Currently the button is not focussed after editing here. Please report back if this still works with recent `main` for you (I've just rebased, because the parent sha1 was some weeks old).
  17. Benjamin Franzke commented on patch set 7 04/28/26, 07:13

    Please make sure to always prepend `#`, otherwise the association to the ticket is not created. You can see that on https://forge.typo3.org/issues/109017 that patchset 7 is the first one that was picked up. No further action required here, just wanted to mention.
  18. core-ci voted on patch set 7 V -1 04/28/26, 07:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101206

  19. core-ci commented on patch set 7 04/28/26, 08:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101206

  20. Christian Jung abandoned the change 05/20/26, 09:52