Review main Merged

93554[BUGFIX] Fix isSubMenu excluding Link pages from menu children

Nikita Kirin CR +2 V +2 Easy +10 −1 updated 04/15/26, 07:58

Commit message

isSubMenu() used a hardcoded field list when fetching child pages
in a batch query. The checkValidLinkOfPage() method introduced in
14.0 requires the "link" field, which was absent from that list.
As a result, all Link pages (doktype=3) were removed during
validation, causing isSubMenu() to cache a negative result and
skip the submenu query entirely, leaving children empty.

Fix by using * in the batch query to ensure all fields required
by checkShortcuts validation are available. Strip the result down
to only the fields consumed by the foreach loop before caching
to keep the runtime cache lean.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Nikita Kirin uploaded patch set 1 04/07/26, 14:40

  2. core-ci voted on patch set 1 V +1 04/07/26, 14:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99705

  3. Georg Ringer updated the commit message in patch set 2 V +1 04/07/26, 19:46

  4. core-ci voted on patch set 2 V +1 04/07/26, 19:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99718

  5. Stefan Bürk commented on patch set 2 04/08/26, 04:25

    The issue was reported for v14, and also states that the checks has been introduced in v14 leading to the issue - do we really need the 13.4 backport if there is no reason ?
  6. Georg Ringer voted on patch set 2 CR +1 V +1 04/15/26, 06:33

  7. Stefan Bürk voted on patch set 2 CR +2 V +2 04/15/26, 07:50

  8. Stefan Bürk commented on patch set 2 04/15/26, 07:58

    Reply

    Done
  9. Stefan Bürk merged patch set 3 04/15/26, 07:58