Review main Merged

93559[TASK] Optimize dialog when prompting for BE user language

Michael Schams CR +2 V +2 Easy +1 −1 updated 08/18/26, 11:57

Commit message

TYPO3's default and main language is English. This patch updates the
wording of the language prompt when creating a new backend user through
the TYPO3 CLI.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • Sebastian Fischer +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1317

  1. Michael Schams uploaded patch set 1 04/08/26, 04:44

  2. core-ci voted on patch set 1 V -1 04/08/26, 04:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99729

  3. Michael Schams rebased onto patch set 2 V -1 04/08/26, 06:31

  4. core-ci voted on patch set 2 V +1 04/08/26, 06:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99737

  5. Josua Vogel commented on patch set 2 04/08/26, 06:46

    CreateBackendUserCommand.php:338

    should we add 'en' as default value? Then we can omit mentioning "default: en".
  6. Benni Mack updated the commit message in patch set 3 V +1 04/22/26, 07:29

  7. Benni Mack rebased onto patch set 4 08/14/26, 13:47

  8. core-ci voted on patch set 4 V +1 08/14/26, 14:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106704

  9. Oliver Klee commented on patch set 4 08/14/26, 14:25

    CreateBackendUserCommand.php:338

    If we use double quotes for the string, we can avoid having to quote the lone single quote.
  10. Michael Schams uploaded patch set 5 V +1 08/17/26, 05:16

  11. Michael Schams commented on patch set 5 08/17/26, 05:21

    CreateBackendUserCommand.php:338 Reply

    Done

    CreateBackendUserCommand.php:338 Reply

    That's true. However, all the other strings in this file use single quotes. For consistency, I suggest we stick with that format.
  12. core-ci voted on patch set 5 V +1 08/17/26, 05:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106801

  13. Oliver Klee commented on patch set 5 08/17/26, 08:08

    CreateBackendUserCommand.php:338 Reply

    Acknowledged
  14. Oliver Klee voted on patch set 5 CR +1 V +1 08/17/26, 08:09

  15. Garvin Hicking voted on patch set 5 CR +2 V +2 08/17/26, 18:54

  16. Garvin Hicking merged patch set 6 08/18/26, 05:51

  17. Sebastian Fischer voted on patch set 6 CR +1 08/18/26, 11:57