Review main Merged

93561[BUGFIX] Restore form list position after closing the editor

Amir Arends CR +2 V +2 Easy +7 −3 updated 04/08/26, 19:02

Commit message

When opening a form for editing, the form manager did not pass a
returnUrl to the form editor. The close button therefore always
redirected back to the first page of the list, discarding any
active pagination, search term or sort order.

Fix this by capturing the current request URI in indexAction()
and passing it as returnUrl when building each form's edit URL
inside getAvailableFormDefinitions().

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Sebastian Michaelsen +1
    • Josua Vogel +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Sebastian Michaelsen +1
    • Josua Vogel +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 811

  1. Amir Arends uploaded patch set 1 04/08/26, 05:45

  2. Amir Arends updated the commit message in patch set 2 04/08/26, 05:47

  3. Amir Arends updated the commit message in patch set 3 04/08/26, 05:51

  4. core-ci voted on patch set 1 V +1 04/08/26, 05:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99733

  5. core-ci voted on patch set 2 V +1 04/08/26, 05:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99734

  6. core-ci voted on patch set 3 V +1 04/08/26, 06:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99735

  7. Josua Vogel commented on patch set 3 CR +1 V +1 04/08/26, 06:39

    thx @amir.arends@gmail.com!
  8. Sebastian Michaelsen commented on patch set 3 CR +1 V +1 04/08/26, 06:46

    Works very well, thank you. Since 13.4 still has "regular maintenance", should we also backport this?
  9. Josua Vogel commented on patch set 3 04/08/26, 06:53

    Reply

    The fix for 13.4 would be completely different. I wouldn't fix it, then. There haven't been any complaints so far, and it's more of a UX improvement than a serious bug.
  10. Garvin Hicking voted on patch set 3 CR +2 V +2 04/08/26, 19:02

  11. Garvin Hicking merged patch set 4 04/08/26, 19:02