Review main Merged

93569[TASK] Avoid GU::getIndpEnv() in PublicUrlPrefixer

Christian Kuhn CR +2 V +2 Easy +9 −3 updated 04/09/26, 15:13

Commit message

PublicUrlPrefixer is a FE & BE FAL hack to incorporate a
request dependency into FAL URL generation.

We dealt with the FE part with #107831 already - hacking
around the issue, but not resolving the root cause.

PublicUrlPrefixer in BE suffers from a similar issue, this
time based on a GU::getIndpEnv() that we're eager to get
rid of now, again without resolving the root cause. The
patch switches to $GLOBALS['TYPO3_REQUEST'] and comments
the offending code section more prominently.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 57

  1. Christian Kuhn uploaded patch set 1 04/08/26, 16:57

  2. core-ci voted on patch set 1 V +1 04/08/26, 17:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99780

  3. Christian Kuhn rebased onto patch set 2 V +1 04/08/26, 17:15

  4. core-ci voted on patch set 2 V +1 04/08/26, 17:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99783

  5. Stefan Bürk voted on patch set 2 CR +1 V +1 04/09/26, 14:50

  6. Benni Mack voted on patch set 2 CR +2 V +2 04/09/26, 15:13

  7. Benni Mack merged patch set 3 04/09/26, 15:13