Review main Merged

93570[BUGFIX] Return correct available nested Fluid components

Simon Praetorius CR +2 V +2 Easy +8 −1 updated 04/08/26, 19:47

Commit message

`DeclarativeComponentCollection` implements
`ComponentListProviderInterface` to provide a list of all available
Fluid components, which is used to generate XSD schema files for
components. However, this didn't work correctly for nested components
because the `.` separator wasn't handled properly from the component
names.

This patch makes sure that empty path segments are stripped, which
leads to `category.subComponent` instead of `category..subComponent`
in the generated XSD files.

Review

  • Code review CR +2 Done
    • Simon Praetorius +2
    • Richard Krikler +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Simon Praetorius +2
    • Richard Krikler +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 79

  1. Simon Praetorius uploaded patch set 1 04/08/26, 17:17

  2. core-ci voted on patch set 1 V -1 04/08/26, 17:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99784

  3. Simon Praetorius uploaded patch set 2 V -1 04/08/26, 17:49

  4. Simon Praetorius marked it ready for review 04/08/26, 17:49

  5. core-ci voted on patch set 2 V +1 04/08/26, 17:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99788

  6. Christian Kuhn voted on patch set 2 CR +1 V +1 04/08/26, 18:37

  7. Richard Krikler voted on patch set 2 CR +1 V +1 04/08/26, 19:42

  8. Simon Praetorius voted on patch set 2 CR +2 V +2 04/08/26, 19:47

  9. Simon Praetorius merged patch set 3 04/08/26, 19:47