Review main Merged

93573[DOCS] Remove invalid named arguments from changelog example

Garvin Hicking CR +2 V +2 Easy +28 −3 updated 04/08/26, 22:15

Commit message

The changelog to feature #109187 contained a PHP code example
on how to access the PageRenderer CSS/JS methods and specify
an `$integrity` parameter.

This was done for brevity with a named argument example.

However, according to the TYPO3 Core guideline for named
arguments, these must not be used for regular methods,
even if convenient for a code example. The name `$integrity`
is not part of our API contract, and thus the name must
not be used in this context, especially for boilerplate
code that might be copied to custom extensions.

The new code example uses the current defaults (which
may of course change in future TYPO3 versions, and already
contain dropped method parameters that require NULL values)
and contains a small code comment to explain why the hell
so many parameters are shown there, and that only the
last one counts.

Emphasis is put onto these specific lines in the changelog
rendering.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 56

  1. Garvin Hicking uploaded patch set 1 04/08/26, 19:51

  2. Christian Kuhn voted on patch set 1 CR +1 V +1 04/08/26, 19:57

  3. core-ci voted on patch set 1 V +1 04/08/26, 20:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99795

  4. Simon Schaufelberger voted on patch set 1 CR +1 V +1 04/08/26, 22:07

  5. Christian Kuhn commented on patch set 1 CR +2 V +2 04/08/26, 22:13

    pagerenderer details are hilarious. always have been. i'm sure we're on a good track to find a better solution in v15
  6. Christian Kuhn merged patch set 2 04/08/26, 22:15