Review main Merged

93575[TASK] Deprecate GeneralUtility::isOnCurrentHost() without request

Christian Kuhn CR +2 V +2 Normal +144 −16 updated 04/09/26, 18:26

Commit message

TYPO3 aims to dissolve `GU::getIndpEnv()` as it hides implicit
`$_SERVER` access behind a caching layer. `isOnCurrentHost()` was one
such caller.

The patch extends the signature with a mandatory PSR-7 request argument,
deprecating calls without it. Core callers in `DefaultSanitizerBuilder`
and `LinkFactory::isInternalUrl()` are updated to pass the request
explicitly. An extension scanner entry flags third-party code.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 810

  1. Christian Kuhn uploaded patch set 1 04/08/26, 21:41

  2. core-ci voted on patch set 1 V +1 04/08/26, 21:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99801

  3. Oliver Klee updated the commit message in patch set 2 V +1 04/09/26, 07:15

  4. core-ci voted on patch set 2 V +1 04/09/26, 07:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99821

  5. Stefan Bürk voted on patch set 2 CR +1 V +1 04/09/26, 15:27

  6. Benni Mack commented on patch set 2 04/09/26, 16:35

    LinkFactory.php:353

    I think we should add a host name of the request to the cache identifier, obviously we've been hiding the request dependency here - which just came to light now
  7. Christian Kuhn commented on patch set 2 04/09/26, 17:33

    LinkFactory.php:353 Reply

    nice one. is it ok with you to fix in a dedicated patch?
  8. Benni Mack commented on patch set 2 CR +1 V +1 04/09/26, 17:49

    LinkFactory.php:353 Reply

    Yes. Of course. We will put it on our lolli-Benni-later list.
  9. Christian Kuhn voted on patch set 2 CR +2 V +2 04/09/26, 18:26

  10. Christian Kuhn merged patch set 3 04/09/26, 18:26