93575[TASK] Deprecate GeneralUtility::isOnCurrentHost() without request
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 9
- typo3/sysext/core/Classes/Html/DefaultSanitizerBuilder.php+13 −5
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+21 −3
- typo3/sysext/core/Documentation/Changelog/14.3/Deprecation-109523-GeneralUtilityIsOnCurrentHostWithoutRequest.rstnew+61 −0
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/SecurityTest.php+4 −0
- typo3/sysext/core/Tests/Functional/Html/DefaultSanitizerBuilderTest.php+4 −0
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php+23 −4
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Sanitize/HtmlViewHelperTest.php+6 −0
- typo3/sysext/frontend/Classes/Typolink/LinkFactory.php3+5 −4
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodArgumentRequiredStaticMatcher.php+7 −0
Review log 810
-
Christian Kuhn uploaded patch set 1 04/08/26, 21:41
-
core-ci voted on patch set 1 V +1 04/08/26, 21:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99801
-
Oliver Klee updated the commit message in patch set 2
V +104/09/26, 07:15 -
core-ci voted on patch set 2 V +1 04/09/26, 07:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99821
-
Stefan Bürk voted on patch set 2 CR +1 V +1 04/09/26, 15:27
-
Benni Mack commented on patch set 2 04/09/26, 16:35
-
Christian Kuhn commented on patch set 2 04/09/26, 17:33
LinkFactory.php:353Replynice one. is it ok with you to fix in a dedicated patch? -
Benni Mack commented on patch set 2 CR +1 V +1 04/09/26, 17:49
LinkFactory.php:353ReplyYes. Of course. We will put it on our lolli-Benni-later list. -
Christian Kuhn voted on patch set 2 CR +2 V +2 04/09/26, 18:26
-
Christian Kuhn merged patch set 3 04/09/26, 18:26
LinkFactory.php:353