Review main Merged

93592[BUGFIX] Allow pid `0` in tableDef for cache config

Ravi Sachaniya CR +2 V +2 Easy +1 −1 updated 04/09/26, 15:33

Commit message

Previously, when a cache configuration like sys_file_metadata:0
was used, the empty function that returned true caused errors in
the tableDef cache configuration.

This fix ensures that pid 0 is properly handled without
throwing errors.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Ravi Sachaniya uploaded patch set 1 04/09/26, 06:42

  2. core-ci voted on patch set 1 V +1 04/09/26, 06:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99818

  3. Oliver Klee voted on patch set 1 CR +1 04/09/26, 07:14

  4. Christian Kuhn commented on patch set 1 04/09/26, 09:51

    imho a v13 candidate, too.
  5. Christian Kuhn updated the commit message in patch set 2 CR +1 V +1 04/09/26, 09:52

  6. Christian Kuhn voted on patch set 2 CR +1 V +1 04/09/26, 09:52

  7. Oliver Klee voted on patch set 2 CR +1 04/09/26, 09:58

  8. core-ci voted on patch set 2 V +1 04/09/26, 10:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99834

  9. Stefan Bürk voted on patch set 2 CR +1 V +1 04/09/26, 14:41

  10. Stefan Bürk voted on patch set 2 CR +2 V +2 04/09/26, 14:41

  11. Stefan Bürk merged patch set 3 04/09/26, 15:33