93596[BUGFIX] Render database forms in frontend without BE user requirement
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Garvin Hicking +1
-
Verified V +2 Done
- Georg Ringer +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 3
Files 5
- typo3/sysext/form/Classes/Mvc/Persistence/FormPersistenceManager.php+3 −3
- typo3/sysext/form/Classes/Storage/DatabaseStorageAdapter.php+10 −2
- typo3/sysext/form/Classes/Storage/ExtensionStorageAdapter.php+2 −1
- typo3/sysext/form/Classes/Storage/FileMountStorageAdapter.php+2 −1
- typo3/sysext/form/Classes/Storage/StorageAdapterInterface.php2+2 −1
Review log 1117
-
Stefan Bürk uploaded patch set 1 04/09/26, 10:00
-
Stefan Bürk updated the commit message in patch set 2 04/09/26, 10:01
-
core-ci voted on patch set 1 V +1 04/09/26, 10:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99835
-
core-ci voted on patch set 2 V +1 04/09/26, 10:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99836
-
Josua Vogel uploaded patch set 3
V +104/09/26, 11:24 -
Stefan Bürk commented on patch set 3 04/09/26, 11:30
-
core-ci voted on patch set 3 V -1 04/09/26, 11:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99842
-
Stefan Bürk commented on patch set 3 04/09/26, 11:42
StorageAdapterInterface.php:113ReplyOr not. The interface and implementation are `@internal`. Missed that. -
Stefan Bürk commented on patch set 4
V -104/09/26, 11:43Published edit on patch set 3. -
core-ci voted on patch set 4 V +1 04/09/26, 12:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99847
-
Stefan Bürk updated the commit message in patch set 5
V +104/09/26, 12:45 -
core-ci voted on patch set 5 V +1 04/09/26, 12:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99853
-
Garvin Hicking updated the commit message in patch set 6
V +104/09/26, 16:24 -
core-ci voted on patch set 6 V +1 04/09/26, 16:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99873
-
Garvin Hicking commented on patch set 6 CR +1 V +1 04/09/26, 18:52
Unresolved
Thanks for noticing, and guilty as charged: I did my tests in the same browser, thus having a valid backend user login active. I'm really sorry that this slipped my review. Having said that: I already contacted Josua, we definitely need a frontend-based functional test to fixate the behavior, especially given we want to touch this in v15 again. I think we should be able to some something along the lines of https://review.typo3.org/c/Packages/TYPO3.CMS/+/90226: Setup a dummy site, fixture with tt_content form pi1 plugin, request the frontend URI as a subrequest, do assertions, submit a dummy YAML form (once loaded from deprecated filesystem, once loaded with the DB adapter), using a YAML that has a savetoDbFinisher enabled. Then assert that the submitted form contains the data and is persisted. Then test this once with a valid BE authentication, and once without. I don't mind creating that test independently from this bugfix, but it would make it better to review if we added the regression test case inside here. -
Georg Ringer voted on patch set 6 CR +2 V +2 04/09/26, 20:02
-
Georg Ringer merged patch set 7 04/09/26, 20:02
StorageAdapterInterface.php:113