Review main Merged

93598[TASK] Deprecate page module section markup events

Benjamin Kott CR +2 V +2 Normal +116 −65 updated 04/09/26, 15:39

Commit message

The PSR-14 events BeforeSectionMarkupGeneratedEvent and
AfterSectionMarkupGeneratedEvent (and their shared
AbstractSectionMarkupGeneratedEvent base class) were introduced in
TYPO3 v10.3 alongside the legacy PageLayoutView class to enrich
backend layout columns with custom markup. They expose raw HTML
strings as a column-level extension point and force every refactoring
of the page module to keep emitting that markup at exactly the same
position in the DOM. This makes it impossible to keep them stable
across versions while improving the page module: ongoing work to
rebuild the page module and its drag, drop and paste behavior cannot
proceed without locking the column's internal structure to whatever
the events happened to assume.

The two events, the abstract base, and the matching
GridColumn::getBeforeSectionMarkup() / getAfterSectionMarkup() getters
are therefore deprecated and will be removed in TYPO3 v15. Calling
AbstractSectionMarkupGeneratedEvent::setContent() now triggers an
E_USER_DEPRECATED warning. Existing listeners keep working in v14:
the dispatch sites still fire and the Fluid templates still render
the resulting strings.

The only listener that still consumed the event in the core,
PageLayoutViewDrawEmptyColposContent, is removed. Its job — showing
a placeholder for backend layout cells that have no colPos
configured — is now performed directly in
PageLayout/Grid/Column.fluid.html via an {column.unassigned}
condition and rendered through f:be.infobox, replacing the previous
fake content-element block with a standard backend warning notice.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 45

  1. Benjamin Kott uploaded patch set 1 04/09/26, 11:42

  2. Benjamin Franzke voted on patch set 1 CR +1 V +1 04/09/26, 11:54

  3. core-ci voted on patch set 1 V +1 04/09/26, 12:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99843

  4. Benni Mack voted on patch set 1 CR +2 V +2 04/09/26, 15:39

  5. Benni Mack merged patch set 2 04/09/26, 15:39