Review main Abandoned

93601[DOCS] Update EXT:redirects documentation for clearer config syntax

TYPO3com CR 0 V 0 Easy +1 −0 updated 06/05/26, 00:15

Commit message

This patch adds a caption to indicate that the displayed array
structure depends on a TYPO3_CONF_VARS setting. It looks differently,
depending on whether you adjust it in `system/settings.php`:

```
$GLOBALS['TYPO3_CONF_VARS']['SYS']['features']['redirects.hitCount'] = true;
```

or in `system/additional.php`:

```
$GLOBALS['TYPO3_CONF_VARS'] = array_replace_recursive(
  $GLOBALS['TYPO3_CONF_VARS'],
  [
    'SYS' => [
        'features' => [
            'redirects.hitCount' => true
        ],
    ],
  ],
);
```

Both syntaxes utilize basic PHP array manipulation and need to be
known by system maintainers; neither is "right" or "wrong",
but both are possible to utilize.

Since the latter syntax can be better formatted, and is often
used in other documentation examples, a caption is added.

Showing both ways would be too much overhead.

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 1

Review log 812

  1. TYPO3com uploaded patch set 1 04/09/26, 13:38

  2. core-ci voted on patch set 1 V +1 04/09/26, 13:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99855

  3. Georg Ringer voted on patch set 1 CR +1 V +1 04/09/26, 14:25

  4. Garvin Hicking commented on patch set 1 CR -1 04/09/26, 14:28

    Meeds [DOCS] prefix Needs a better title Also I'd argue the current way is way more legible. Better add a caption to indicate this is part of TYPO3_CONf_VARS
  5. Stefan Bürk commented on patch set 1 04/09/26, 14:39

    Reply

    IMO we need different example if we want to talk about "legit". For `system.php` the existing example is correct, but not for `additional.php`. The changed example is valid for `additional.php`, but not for `system.php`. Time to split that up and avoid that tomorrow the next one opens again to revert this arguing that its invalid for system.php. Regarding the rest --- yes, title and commit message needs to state more context than saying nothing.
  6. Garvin Hicking uploaded patch set 2 CR +1 V +1 04/09/26, 19:27

  7. Garvin Hicking commented on patch set 2 04/09/26, 19:29

    Reply Unresolved

    Thanks "Marc" for the contribution. I was a bit short on time when I wrote this. I've adjusted the commit message and headline and changed this to use a caption. However, I don't really think this change is improving the current situation much, as it is basic PHP syntax. Not voting myself, but anyone feel free to merge with sufficient votes. (Otherwise, we should abandon it and not let it stay in limbo)
  8. core-ci voted on patch set 2 V +1 04/09/26, 19:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99881

  9. Benni Mack updated the commit message in patch set 3 V +1 04/22/26, 06:45

  10. core-ci voted on patch set 3 V +1 04/22/26, 11:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100786

  11. Christian Kuhn commented on patch set 3 06/05/26, 00:15

    hey. i hope it is ok to abandon here at the moment: the change itself does not really help much and raises further questions. let's start a-new if this should be improved.
  12. Christian Kuhn abandoned the change 06/05/26, 00:15