Review main Merged

93603[BUGFIX] Derive workspace preview handling from event context

Matthias Vogel CR +2 V +2 Easy +2 −1 updated 04/13/26, 11:30

Commit message

The workspace hook decides early whether preview URI processing is
needed. Reading the workspace from the event context makes that
decision depend on the current preview state instead of the backend
user object.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 910

  1. Matthias Vogel uploaded patch set 1 04/09/26, 15:28

  2. core-ci voted on patch set 1 V +1 04/09/26, 15:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99870

  3. Matthias Vogel marked it ready for review 04/09/26, 15:38

  4. Christian Kuhn commented on patch set 1 04/12/26, 18:25

    could you state what is actually broken without the patch and how to test? this looks kinda obvious at first glance, though ...
  5. Christian Kuhn commented on patch set 1 04/12/26, 18:27

    Reply

    i'm asking since there is no 'what fails' statement in the issue, either. and since this is a bugfix, we should pin the bug.
  6. Matthias Vogel commented on patch set 1 04/13/26, 08:36

    Reply

    I added a detailed description to the issue: https://forge.typo3.org/issues/109532
  7. Christian Kuhn voted on patch set 1 CR +1 V +1 04/13/26, 09:57

  8. Stefan Bürk voted on patch set 1 CR +1 V +1 04/13/26, 10:44

  9. Christian Kuhn voted on patch set 1 CR +2 V +2 04/13/26, 11:13

  10. Christian Kuhn merged patch set 2 04/13/26, 11:30