Review main Merged

93608[TASK] Avoid GU::getIndpEnv() in ext:install SecurityStatus

Christian Kuhn CR +2 V +2 Easy +22 −21 updated 04/11/26, 07:08

Commit message

The ext:install related 'security status' check (part of
'Environment status' and run in reports module as well)
uses GU::getIndpEnv() to create test requests.

The patch avoids this by handing around the current request.
This part of the code base is @internal, the changes
are not considered breaking.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 911

  1. Christian Kuhn uploaded patch set 1 04/09/26, 19:20

  2. core-ci voted on patch set 1 V +1 04/09/26, 19:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99880

  3. Christian Kuhn updated the commit message in patch set 2 V +1 04/09/26, 19:33

  4. core-ci voted on patch set 2 V +1 04/09/26, 19:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99882

  5. Stefan Bürk voted on patch set 2 CR +1 04/10/26, 18:51

  6. Stefan Bürk voted on patch set 2 V +1 04/10/26, 18:57

  7. Simon Schaufelberger voted on patch set 2 CR +1 V +1 04/10/26, 22:58

  8. Anja Leichsenring voted on patch set 2 CR +1 V +1 04/11/26, 04:46

  9. Oliver Klee voted on patch set 2 CR +1 V +1 04/11/26, 06:03

  10. Christian Kuhn voted on patch set 2 CR +2 V +2 04/11/26, 07:08

  11. Christian Kuhn merged patch set 3 04/11/26, 07:08