Review main Merged

93609[TASK] Separate frontend from backend PageRenderer::render()

Christian Kuhn CR +2 V +2 Hard +323 −258 updated 04/11/26, 07:00

Commit message

Probably the last v14 PageRenderer change. Goal is to further
prepare towards v15 refactoring. PageRenderer is used in both
FE and BE contexts. It will be helpful to separate the two
scopes a bit more. To achieve that, render() is now declared
BE scope only (where it is API for extensions that don't use
ModuleTemplate), while FE switches to an own new method. That
one is declared `@internal` since FE extensions usually don't
need to deal with this low level layer directly.

We also sort the PageRenderer methods around a bit to increase
overview, and leave various comments to clarify FE and/or BE
scope.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 810

  1. Christian Kuhn uploaded patch set 1 04/09/26, 22:45

  2. core-ci voted on patch set 1 V +1 04/09/26, 22:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99885

  3. Oliver Klee updated the commit message in patch set 2 V +1 04/10/26, 12:18

  4. core-ci voted on patch set 2 V +1 04/10/26, 12:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99920

  5. Stefan Bürk voted on patch set 2 CR +1 V +1 04/10/26, 18:50

  6. Simon Schaufelberger commented on patch set 2 04/10/26, 23:00

    I really don't like it that you moved so many methods around in the same file. This makes it so much more difficult to review (and also backport).
  7. Simon Schaufelberger commented on patch set 2 04/10/26, 23:02

    Reply

    since these methods are deprecated anyway and will be deleted, can't they just stay until final deletion?
  8. Anja Leichsenring voted on patch set 2 CR +1 V +1 04/11/26, 04:50

  9. Christian Kuhn commented on patch set 2 CR +2 V +2 04/11/26, 07:00

    Reply

    i'm sorry. i should have pushed the true code change as set 1 to simplify reviewing. since the class is so long and such a mess of state, i really wanted to have a final v14 version with public methods on top, then protected/private, then deprecated. this makes reading, understanding of impact and editing (in IDE's, too) so much easier and clarifies api much better and is imho worth one 'move around' patch in this case.
  10. Christian Kuhn merged patch set 3 04/11/26, 07:00