93610[TASK] Declare more classes readonly
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Georg Ringer +1
- Oliver Klee +1
-
Verified V +2 Done
- Christian Kuhn +2
- Georg Ringer +1
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 166
- typo3/sysext/adminpanel/Classes/Middleware/SqlLogging.php+2 −2
- typo3/sysext/backend/Classes/Backend/Avatar/Avatar.php+5 −5
- typo3/sysext/backend/Classes/Backend/Bookmark/BookmarkRepository.php+2 −2
- typo3/sysext/backend/Classes/Backend/Bookmark/BookmarkService.php+8 −8
- typo3/sysext/backend/Classes/Breadcrumb/NullContextBreadcrumbProvider.php+4 −4
- typo3/sysext/backend/Classes/Controller/CodeEditor/CodeCompletionController.php+5 −5
- typo3/sysext/backend/Classes/Controller/Page/SortSubPagesController.php+4 −4
- typo3/sysext/backend/Classes/Controller/PageTsConfig/PageTsConfigActiveController.php+5 −5
- typo3/sysext/backend/Classes/Controller/PageTsConfig/PageTsConfigRecordsOverviewController.php+4 −4
- typo3/sysext/backend/Classes/Controller/Wizard/ImageManipulationController.php+3 −3
- typo3/sysext/backend/Classes/Controller/Wizard/SuggestWizardController.php+3 −3
- typo3/sysext/backend/Classes/Controller/AboutController.php+7 −7
- typo3/sysext/backend/Classes/Controller/AjaxLoginController.php+3 −3
- typo3/sysext/backend/Classes/Controller/BackendController.php+14 −14
- typo3/sysext/backend/Classes/Controller/BookmarkController.php+2 −2
- typo3/sysext/backend/Classes/Controller/ColumnSelectorController.php+4 −4
- typo3/sysext/backend/Classes/Controller/DummyController.php+2 −2
- typo3/sysext/backend/Classes/Controller/FormSelectTreeAjaxController.php+4 −4
- typo3/sysext/backend/Classes/Controller/LiveSearchController.php+4 −4
- typo3/sysext/backend/Classes/Controller/OnlineMediaController.php+5 −5
Show 146 more files
- typo3/sysext/backend/Classes/Controller/SystemInformationController.php+2 −2
- typo3/sysext/backend/Classes/Form/FormDataProvider/InitializeProcessedTca.php+2 −2
- typo3/sysext/backend/Classes/Form/FormDataProvider/SystemMaintainerAsReadonly.php+2 −2
- typo3/sysext/backend/Classes/Localization/ManualLocalizationHandler.php+3 −3
- typo3/sysext/backend/Classes/Middleware/BackendModuleValidator.php+5 −5
- typo3/sysext/backend/Classes/Middleware/BackendRouteInitialization.php+4 −4
- typo3/sysext/backend/Classes/Middleware/ForcedHttpsBackendRedirector.php+2 −2
- typo3/sysext/backend/Classes/Middleware/LockedBackendGuard.php+2 −2
- typo3/sysext/backend/Classes/Middleware/SiteResolver.php+2 −2
- typo3/sysext/backend/Classes/Module/ModuleFactory.php+3 −3
- typo3/sysext/backend/Classes/Module/ModuleProvider.php+3 −3
- typo3/sysext/backend/Classes/Preview/StandardPreviewRendererResolver.php+2 −2
- typo3/sysext/backend/Classes/Search/LiveSearch/SearchDemand/DemandProperty.php+3 −3
- typo3/sysext/backend/Classes/Security/ContentSecurityPolicy/CspAjaxController.php+7 −7
- typo3/sysext/backend/Classes/Security/ContentSecurityPolicy/CspModuleController.php+8 −8
- typo3/sysext/backend/Classes/Security/SudoMode/Access/AccessGrant.php+3 −3
- typo3/sysext/backend/Classes/Security/SudoMode/PasswordVerification.php+2 −2
- typo3/sysext/backend/Classes/View/Drawing/BackendLayoutRenderer.php+3 −3
- typo3/sysext/core/Classes/Adapter/EventDispatcherAdapter.php+2 −2
- typo3/sysext/core/Classes/Charset/CharsetConverter.php+2 −2
- typo3/sysext/core/Classes/Controller/PasswordGeneratorController.php+5 −5
- typo3/sysext/core/Classes/Database/Query/Restriction/PageIdListRestriction.php+3 −3
- typo3/sysext/core/Classes/Database/Query/With.php+6 −6
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/CreateDefinition.php+2 −2
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/IndexColumnName.php+4 −4
- typo3/sysext/core/Classes/Database/Schema/SchemaMigrator.php+6 −6
- typo3/sysext/core/Classes/Domain/Access/RecordAccessVoter.php+3 −3
- typo3/sysext/core/Classes/FormProtection/FormProtectionFactory.php+5 −5
- typo3/sysext/core/Classes/Hooks/UpdateFileIndexEntry.php+2 −2
- typo3/sysext/core/Classes/Http/CookieScope.php+4 −4
- typo3/sysext/core/Classes/Http/FalDumpFileContentsDecoratorStream.php+4 −4
- typo3/sysext/core/Classes/Http/RequestFactory.php+2 −2
- typo3/sysext/core/Classes/Http/RequestHandler.php+3 −3
- typo3/sysext/core/Classes/Http/SelfEmittableLazyOpenStream.php+3 −3
- typo3/sysext/core/Classes/Localization/CacheWarmer.php+5 −5
- typo3/sysext/core/Classes/Localization/TcaSystemLanguageCollector.php+2 −2
- typo3/sysext/core/Classes/Messenger/BusFactory.php+2 −2
- typo3/sysext/core/Classes/Messenger/TransportLocator.php+2 −2
- typo3/sysext/core/Classes/Page/ResourceHashCollection.php+4 −4
- typo3/sysext/core/Classes/RateLimiter/RateLimiterFactory.php+3 −3
- typo3/sysext/core/Classes/Resource/Event/BeforeFileRenamedEvent.php+2 −2
- typo3/sysext/core/Classes/Resource/OnlineMedia/Service/PreviewService.php+3 −3
- typo3/sysext/core/Classes/Resource/Search/QueryRestrictions/SearchTermRestriction.php+3 −3
- typo3/sysext/core/Classes/Resource/Service/ImageProcessingService.php+4 −4
- typo3/sysext/core/Classes/Routing/RequestContextFactory.php+2 −2
- typo3/sysext/core/Classes/Routing/SiteMatcher.php+4 −4
- typo3/sysext/core/Classes/Security/ContentSecurityPolicy/Reporting/ReportRepository.php+2 −2
- typo3/sysext/core/Classes/Security/ContentSecurityPolicy/Reporting/ResolutionRepository.php+2 −2
- typo3/sysext/core/Classes/Security/ContentSecurityPolicy/ModelService.php+2 −2
- typo3/sysext/core/Classes/Security/ContentSecurityPolicy/MutationOrigin.php+3 −3
- typo3/sysext/core/Classes/Security/ContentSecurityPolicy/MutationSuggestion.php+5 −5
- typo3/sysext/core/Classes/Security/ContentSecurityPolicy/RawValue.php+2 −2
- typo3/sysext/core/Classes/Security/ContentSecurityPolicy/ScopeRepository.php+2 −2
- typo3/sysext/core/Classes/Security/SecretIdentifier.php+2 −2
- typo3/sysext/core/Classes/SystemResource/Type/UriResource.php+2 −2
- typo3/sysext/core/Classes/TypoScript/IncludeTree/StringTreeBuilder.php+2 −2
- typo3/sysext/core/Classes/TypoScript/IncludeTree/TsConfigTreeBuilder.php+6 −6
- typo3/sysext/core/Classes/TypoScript/TypoScriptStringFactory.php+3 −3
- typo3/sysext/core/Classes/TypoScript/UserTsConfig.php+3 −3
- typo3/sysext/core/Classes/Upgrades/BackendUserLanguageMigration.php+2 −2
- typo3/sysext/core/Classes/Upgrades/NullToDefaultUpdateWizard.php+3 −3
- typo3/sysext/core/Classes/Upgrades/SysFileMimeTypeMigration.php+2 −2
- typo3/sysext/core/Classes/Upgrades/UpgradeWizardRegistry.php+2 −2
- typo3/sysext/core/Classes/Utility/String/StringFragmentPattern.php+3 −3
- typo3/sysext/core/Classes/Validation/ResultMessage.php+3 −3
- typo3/sysext/dashboard/Classes/Controller/DashboardAjaxController.php+8 −8
- typo3/sysext/dashboard/Classes/Controller/DashboardController.php+4 −4
- typo3/sysext/dashboard/Classes/DependencyInjection/DashboardWidgetPass.php+2 −2
- typo3/sysext/dashboard/Classes/EventListener/AfterBackendPageRenderEventListener.php+2 −2
- typo3/sysext/dashboard/Classes/Widgets/Provider/ButtonProvider.php+4 −4
- typo3/sysext/dashboard/Classes/Widgets/Provider/SysLogButtonProvider.php+4 −4
- typo3/sysext/dashboard/Classes/Widgets/Provider/TypeOfUsersChartDataProvider.php+2 −2
- typo3/sysext/dashboard/Classes/Widgets/LatestChangedPagesWidget.php+6 −6
- typo3/sysext/dashboard/Classes/Widgets/RssWidget.php+6 −6
- typo3/sysext/dashboard/Classes/Widgets/WidgetConfiguration.php+10 −10
- typo3/sysext/dashboard/Classes/DashboardPreset.php+7 −7
- typo3/sysext/dashboard/Classes/WidgetGroup.php+2 −2
- typo3/sysext/dashboard/Classes/WidgetGroupInitializationService.php+3 −3
- typo3/sysext/extbase/Classes/Attribute/Authorize.php+4 −4
- typo3/sysext/extbase/Classes/Attribute/RateLimit.php+5 −5
- typo3/sysext/extbase/Classes/Service/FileHandlingService.php+8 −8
- typo3/sysext/extensionmanager/Classes/Report/ExtensionComposerStatus.php+3 −3
- typo3/sysext/felogin/Classes/Domain/Repository/FrontendUserRepository.php+3 −3
- typo3/sysext/felogin/Classes/Redirect/RedirectModeHandler.php+5 −5
- typo3/sysext/filelist/Classes/Controller/FileUpdateOnlineMediaController.php+6 −6
- typo3/sysext/filelist/Classes/Dto/UserPermissions.php+2 −2
- typo3/sysext/filelist/Classes/Event/ProcessFileListActionsEvent.php+5 −5
- typo3/sysext/fluid/Classes/Core/ViewHelper/ViewHelperResolverFactory.php+5 −5
- typo3/sysext/form/Classes/Domain/Configuration/FormDefinitionConversionService.php+2 −2
- typo3/sysext/form/Classes/Service/CleanupFormUploadsService.php+3 −3
- typo3/sysext/form/Classes/Service/FormEditorEnrichmentService.php+2 −2
- typo3/sysext/form/Classes/Service/RichTextConfigurationService.php+6 −6
- typo3/sysext/form/Classes/Upgrades/FileFormsToDatabaseUpgradeWizard.php+4 −4
- typo3/sysext/frontend/Classes/ContentObject/ContentDataProcessor.php+3 −3
- typo3/sysext/frontend/Classes/Controller/ErrorController.php+2 −2
- typo3/sysext/frontend/Classes/DataProcessing/DatabaseQueryProcessor.php+2 −2
- typo3/sysext/frontend/Classes/DataProcessing/DataProcessorRegistry.php+2 −2
- typo3/sysext/frontend/Classes/Middleware/EidHandler.php+2 −2
- typo3/sysext/frontend/Classes/Middleware/PreviewSimulator.php+2 −2
- typo3/sysext/frontend/Classes/Middleware/StaticRouteResolver.php+5 −5
- typo3/sysext/frontend/Classes/Typolink/DatabaseRecordLinkBuilder.php+5 −5
- typo3/sysext/impexp/Classes/Controller/ImportController.php+6 −6
- typo3/sysext/install/Classes/Authentication/AuthenticationService.php+3 −3
- typo3/sysext/install/Classes/Controller/BackendModuleController.php+3 −3
- typo3/sysext/install/Classes/Controller/InstallerController.php+12 −12
- typo3/sysext/install/Classes/Controller/ServerResponseCheckController.php+2 −2
- typo3/sysext/install/Classes/Middleware/Installer.php+4 −4
- typo3/sysext/install/Classes/Report/InstallStatusReport.php+2 −2
- typo3/sysext/install/Classes/Service/ClearCacheService.php+3 −3
- typo3/sysext/install/Classes/Service/LoadTcaService.php+2 −2
- typo3/sysext/install/Classes/Service/SilentTemplateFileUpgradeService.php+2 −2
- typo3/sysext/install/Classes/Service/Typo3tempFileService.php+3 −3
- typo3/sysext/linkvalidator/Classes/EventListener/CheckBrokenRteLinkEventListener.php+2 −2
- typo3/sysext/lowlevel/Classes/Controller/ConfigurationController.php+5 −5
- typo3/sysext/lowlevel/Classes/Localization/Dto/DomainSearchResult.php+4 −4
- typo3/sysext/lowlevel/Classes/Localization/Dto/LabelSearchResult.php+4 −4
- typo3/sysext/opendocs/Classes/Controller/OpenDocumentController.php+7 −7
- typo3/sysext/reactions/Classes/Controller/ManagementController.php+7 −7
- typo3/sysext/reactions/Classes/Http/Middleware/ReactionResolver.php+6 −6
- typo3/sysext/reactions/Classes/Http/ReactionHandler.php+4 −4
- typo3/sysext/reactions/Classes/ReactionRegistry.php+2 −2
- typo3/sysext/recycler/Classes/Controller/RecyclerAjaxController.php+3 −3
- typo3/sysext/redirects/Classes/RedirectUpdate/PageTypeSource.php+5 −5
- typo3/sysext/redirects/Classes/RedirectUpdate/PlainSlugReplacementRedirectSource.php+4 −4
- typo3/sysext/redirects/Classes/RedirectUpdate/SlugRedirectChangeItem.php+8 −8
- typo3/sysext/redirects/Classes/RedirectUpdate/SlugRedirectChangeItemFactory.php+3 −3
- typo3/sysext/redirects/Classes/Report/Status/RedirectStatus.php+5 −5
- typo3/sysext/redirects/Classes/Service/ShortUrlService.php+3 −3
- typo3/sysext/reports/Classes/Report/Status/FalStatus.php+2 −2
- typo3/sysext/rte_ckeditor/Classes/Form/Element/Event/BeforePrepareConfigurationForEditorEvent.php+1 −1
- typo3/sysext/scheduler/Classes/Task/TaskSerializer.php+3 −3
- typo3/sysext/seo/Classes/Widgets/Provider/PagesWithoutDescriptionDataProvider.php+5 −5
- typo3/sysext/setup/Classes/Configuration/UserSettingsTcaConfiguration.php+2 −2
- typo3/sysext/setup/Classes/UserFunctions/UserSettingsItemsProcFunc.php+5 −5
- typo3/sysext/sys_note/Classes/Domain/Repository/SysNoteRepository.php+2 −2
- typo3/sysext/sys_note/Classes/Provider/RecordListProvider.php+2 −2
- typo3/sysext/sys_note/Classes/Widgets/PagesWithInternalNote.php+5 −5
- typo3/sysext/webhooks/Classes/Controller/ManagementController.php+7 −7
- typo3/sysext/webhooks/Classes/Listener/MessageListener.php+4 −4
- typo3/sysext/webhooks/Classes/Listener/PageModificationListener.php+4 −4
- typo3/sysext/webhooks/Classes/Message/PageModificationMessage.php+8 −8
- typo3/sysext/webhooks/Classes/Message/WebhookMessageFactory.php+2 −2
- typo3/sysext/webhooks/Classes/Model/WebhookInstruction.php+12 −12
- typo3/sysext/webhooks/Classes/Model/WebhookType.php+6 −6
- typo3/sysext/webhooks/Classes/Tca/ItemsProcFunc/WebhookTypesItemsProcFunc.php+3 −3
- typo3/sysext/workspaces/Classes/Service/WorkspaceService.php+5 −5
Review log 812
-
Christian Kuhn uploaded patch set 1 04/09/26, 23:21
-
Christian Kuhn uploaded patch set 2 04/09/26, 23:29
-
Christian Kuhn uploaded patch set 3 04/09/26, 23:35
-
core-ci voted on patch set 1 V -1 04/09/26, 23:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99886
-
core-ci voted on patch set 3 V +1 04/09/26, 23:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99888
-
core-ci voted on patch set 2 V -1 04/09/26, 23:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99887
-
Christian Kuhn updated the commit message in patch set 4
V +104/10/26, 00:02 -
core-ci voted on patch set 4 V +1 04/10/26, 00:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99889
-
Georg Ringer voted on patch set 4 CR +1 V +1 04/10/26, 07:04
-
Oliver Klee voted on patch set 4 CR +1 V +1 04/10/26, 07:12
-
Christian Kuhn voted on patch set 4 CR +2 V +2 04/10/26, 09:52
-
Christian Kuhn merged patch set 5 04/10/26, 09:52