Review main Merged

93611[BUGFIX] Migrate ext_emconf.php "state" to package metadata

Helmut Hummel CR +2 V +2 Hard +772 −115 updated 04/15/26, 17:13

Commit message

When `ext_emconf.php` handling was deprecated with #108345, several
metadata fields were still not migrated fully to `composer.json`.

In addition, `LanguagePackService` still reads `ext_emconf.php` directly
to determine extension title and update exclusion, which bypassed the
package metadata abstraction.

This change completes the migration of the `ext_emconf.php` "state"
handling and moves the remaining logic into package metadata.

The former "state" field was used for different purposes, so its values
are now mapped to dedicated metadata:

* "excludeFromUpdates" is migrated to the boolean flag
  `extra.typo3/cms.exclude-from-updates`
* supported stability values are derived from the version string
* unsupported former state values are preserved as build metadata
  attached to the version string

For example, a version such as "1.0.0+obsolete" results in the build
metadata "obsolete", which can still be shown in the Extension Manager.

This also streamlines metadata handling across package loading:

* title and description are taken from package metadata
* update exclusion is taken from package metadata
* version, stability, and build metadata are parsed consistently
* `ext_emconf.php` state information is normalized when converted into
  the internal composer manifest representation

As part of this cleanup, PHP constraints are kept in metadata so they
remain available for checks in classic mode, but they are ignored for
extension dependency ordering.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
    • Oliver Klee +1
    • core-ci +1 CI

Issues 2

Files 14

Review log 2328

Show 23 earlier messages
  1. Helmut Hummel uploaded patch set 1 04/10/26, 07:16

  2. core-ci voted on patch set 1 V +1 04/10/26, 07:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99903

  3. Oliver Klee updated the commit message in patch set 2 V +1 04/10/26, 07:40

  1. core-ci voted on patch set 2 V +1 04/10/26, 07:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99904

  2. Anton Danilov voted on patch set 2 CR +1 04/10/26, 10:13

  3. Anton Danilov voted on patch set 2 V +1 04/10/26, 10:13

  4. Stefan Bürk commented on patch set 2 CR -1 04/10/26, 11:20

    Reviewing ...
  5. Stefan Bürk commented on patch set 2 CR +1 04/10/26, 21:40

    Reply

    Code wise okay so far. Need to play around with it tomorrow. Thus keeping verifed -1 for now.
  6. Stefan Bürk commented on patch set 2 04/10/26, 21:40

    Reply

    minus the remark regarding the -1 ;)
  7. Simon Schaufelberger commented on patch set 2 04/10/26, 22:54

    MetaData.php:160

    a comment what this method does would be extremely helpful to understand what's going on with the regexes and the last part as it's not very easy to understand by reading
  8. Nikita Hovratov commented on patch set 2 04/11/26, 12:55

    Stability.php:2

    Declare strict
  9. Stefan Bürk commented on patch set 2 CR -1 04/11/26, 13:34

    On it ..
  10. Stefan Bürk uploaded patch set 3 CR +1 V +1 04/11/26, 13:54

  11. Stefan Bürk commented on patch set 3 04/11/26, 13:56

    Stability.php:2 Reply

    Done
  12. Stefan Bürk commented on patch set 3 04/11/26, 14:01

    MetaData.php:160 Reply

    Good point. Tried to do so - and that raised a question. Thanks for asking for it.

    MetaData.php:196

    Albeit a complete other regexp, this has the same effect as the regexp in L202. Possible duplicated and one of them can be dropped ?
  13. core-ci voted on patch set 3 V +1 04/11/26, 14:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99972

  14. Helmut Hummel uploaded patch set 4 V +1 04/14/26, 10:23

  15. Helmut Hummel commented on patch set 3 04/14/26, 10:23

    MetaData.php:160 Reply

    does the current state work for you?

    MetaData.php:196 Reply

    yeah, this was from some intermediate state. removed it completely
  16. Helmut Hummel uploaded patch set 5 04/14/26, 10:28

  17. Helmut Hummel commented on patch set 5 04/14/26, 10:29

    Reply

    Done
  18. core-ci voted on patch set 4 V -1 04/14/26, 10:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100136

  19. core-ci voted on patch set 5 V +1 04/14/26, 11:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100137

  20. Georg Ringer voted on patch set 5 CR +1 V +1 04/15/26, 06:34

  21. Stefan Bürk voted on patch set 5 CR +1 V +1 04/15/26, 06:49

  22. Oliver Klee voted on patch set 5 V +1 04/15/26, 07:45

  23. Stefan Bürk commented on patch set 5 CR +2 V +2 04/15/26, 07:46

    MetaData.php:160 Reply

    As far as I know Simon is currently in vacation. Going to close this now as the comment was more about readability.
  24. Stefan Bürk merged patch set 6 04/15/26, 07:46

  25. Helmut Hummel commented on patch set 6 04/15/26, 17:13

    Thank you very much for your help and reviews and the merge!