93611[BUGFIX] Migrate ext_emconf.php "state" to package metadata
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Georg Ringer +1
-
Verified V +2 Done
- Stefan Bürk +2
- Georg Ringer +1
- Oliver Klee +1
- core-ci +1 CI
Issues 2
Files 14
- Build/phpstan/phpstan-baseline.neon+0 −12
- typo3/sysext/core/Classes/Localization/LanguagePackService.php+6 −15
- typo3/sysext/core/Classes/Package/MetaData.php6+123 −5
- typo3/sysext/core/Classes/Package/Package.php+23 −13
- typo3/sysext/core/Classes/Package/PackageManager.php+16 −4
- typo3/sysext/core/Classes/Package/Stability.php2new+29 −0
- typo3/sysext/core/Documentation/Changelog/14.2/Deprecation-108345-Deprecation-of-ext-emconf-php.rst+133 −11
- typo3/sysext/core/Documentation/Changelog/14.2/Feature-108345-No-ext-em-conf-in-classic-mode.rst+124 −26
- typo3/sysext/core/Tests/Unit/Package/Fixtures/ext_emconf.phpnew+19 −0
- typo3/sysext/core/Tests/Unit/Package/MetaDataTest.php+52 −0
- typo3/sysext/core/Tests/Unit/Package/PackageTest.php+213 −0
- typo3/sysext/extensionmanager/Classes/Controller/ListController.php+1 −1
- typo3/sysext/extensionmanager/Classes/Utility/ListUtility.php+32 −27
- typo3/sysext/extensionmanager/Resources/Private/Templates/List/Index.fluid.html+1 −1
Review log 2328
Show 23 earlier messages
-
Helmut Hummel uploaded patch set 1 04/10/26, 07:16
-
core-ci voted on patch set 1 V +1 04/10/26, 07:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99903
-
Oliver Klee updated the commit message in patch set 2
V +104/10/26, 07:40
-
core-ci voted on patch set 2 V +1 04/10/26, 07:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99904
-
Anton Danilov voted on patch set 2 CR +1 04/10/26, 10:13
-
Anton Danilov voted on patch set 2 V +1 04/10/26, 10:13
-
Stefan Bürk commented on patch set 2 CR -1 04/10/26, 11:20
Reviewing ... -
Stefan Bürk commented on patch set 2 CR +1 04/10/26, 21:40
Reply
Code wise okay so far. Need to play around with it tomorrow. Thus keeping verifed -1 for now. -
Stefan Bürk commented on patch set 2 04/10/26, 21:40
Reply
minus the remark regarding the -1 ;) -
Simon Schaufelberger commented on patch set 2 04/10/26, 22:54
MetaData.php:160a comment what this method does would be extremely helpful to understand what's going on with the regexes and the last part as it's not very easy to understand by reading -
Nikita Hovratov commented on patch set 2 04/11/26, 12:55
Stability.php:2Declare strict -
Stefan Bürk commented on patch set 2 CR -1 04/11/26, 13:34
On it .. -
Stefan Bürk uploaded patch set 3
CR +1V +104/11/26, 13:54 -
Stefan Bürk commented on patch set 3 04/11/26, 13:56
Stability.php:2ReplyDone -
Stefan Bürk commented on patch set 3 04/11/26, 14:01
MetaData.php:160ReplyGood point. Tried to do so - and that raised a question. Thanks for asking for it.MetaData.php:196Albeit a complete other regexp, this has the same effect as the regexp in L202. Possible duplicated and one of them can be dropped ? -
core-ci voted on patch set 3 V +1 04/11/26, 14:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99972
-
Helmut Hummel uploaded patch set 4
V +104/14/26, 10:23 -
Helmut Hummel commented on patch set 3 04/14/26, 10:23
MetaData.php:160Replydoes the current state work for you?MetaData.php:196Replyyeah, this was from some intermediate state. removed it completely -
Helmut Hummel uploaded patch set 5 04/14/26, 10:28
-
Helmut Hummel commented on patch set 5 04/14/26, 10:29
Reply
Done -
core-ci voted on patch set 4 V -1 04/14/26, 10:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100136
-
core-ci voted on patch set 5 V +1 04/14/26, 11:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100137
-
Georg Ringer voted on patch set 5 CR +1 V +1 04/15/26, 06:34
-
Stefan Bürk voted on patch set 5 CR +1 V +1 04/15/26, 06:49
-
Oliver Klee voted on patch set 5 V +1 04/15/26, 07:45
-
Stefan Bürk commented on patch set 5 CR +2 V +2 04/15/26, 07:46
MetaData.php:160ReplyAs far as I know Simon is currently in vacation. Going to close this now as the comment was more about readability. -
Stefan Bürk merged patch set 6 04/15/26, 07:46
-
Helmut Hummel commented on patch set 6 04/15/26, 17:13
Thank you very much for your help and reviews and the merge!