Review main Merged

93614[BUGFIX] Provide failsafe DI fallback for DirectiveHashCollection

Oliver Hader CR +2 V +2 Easy +9 −5 updated 04/13/26, 07:23

Commit message

The FailsafeContainer does not support auto-configure, so
DirectiveHashCollection must be wired manually via the install
ServiceProvider. In non-failsafe mode the Symfony DI container
handles both classes through auto-configure, but the ServiceProvider
factory was unconditionally overriding the auto-configured definition
with an incomplete one.

As a consequence, the previous scenario did not use a cache for
collected CSP hashes in the regular backend context. This issue
has been addressed with this change.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Benjamin Franzke +1
    • Oliver Klee +1
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Benjamin Franzke +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 912

  1. Oliver Hader uploaded patch set 1 04/10/26, 09:31

  2. core-ci voted on patch set 1 V +1 04/10/26, 09:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99909

  3. Oliver Hader uploaded patch set 2 V +1 04/10/26, 09:57

  4. core-ci voted on patch set 2 V +1 04/10/26, 10:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99910

  5. Oliver Hader uploaded patch set 3 V +1 04/10/26, 15:17

  6. core-ci voted on patch set 3 V +1 04/10/26, 15:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99925

  7. Oliver Klee voted on patch set 3 CR +1 04/11/26, 05:57

  8. Benjamin Franzke voted on patch set 3 CR +1 V +1 04/12/26, 20:10

  9. Christian Kuhn voted on patch set 3 CR +1 04/12/26, 21:14

  10. Stefan Bürk voted on patch set 3 CR +1 V +1 04/13/26, 00:17

  11. Oliver Hader commented on patch set 3 CR +2 V +2 04/13/26, 07:23

    Thanks folks 😊
  12. Oliver Hader merged patch set 4 04/13/26, 07:23